<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 16, 2014 at 12:51 PM, Samuel F Antao <span dir="ltr"><<a href="mailto:sfantao@us.ibm.com" target="_blank">sfantao@us.ibm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div>
<p><font face="sans-serif">Hi Kostya,</font><br>
<br>
<font face="sans-serif">Thanks for reviewing the patch. I currently do not have commit privileges, do I need to take any action for the patch to be committed?</font></p></div></blockquote><div>Ok. committed as r217904.</div><div>Thanks! </div><div><br></div><div>--kcc </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><p><br>
<br>
<font face="sans-serif">Thanks,</font><br>
<font face="sans-serif">Sam</font><br>
<br>
<img width="16" height="16" src="cid:1__=0ABBF7C6DFF471388f9e8a93df938@us.ibm.com" border="0" alt="Inactive hide details for Kostya Serebryany ---09/15/2014 04:51:12 PM---LGTM On Wed, Sep 10, 2014 at 4:32 PM, Samuel F Antao <s"><font color="#424282" face="sans-serif">Kostya Serebryany ---09/15/2014 04:51:12 PM---LGTM On Wed, Sep 10, 2014 at 4:32 PM, Samuel F Antao <<a href="mailto:sfantao@us.ibm.com" target="_blank">sfantao@us.ibm.com</a>> wrote:</font><br>
<br>
<font size="1" color="#5F5F5F" face="sans-serif">From: </font><font size="1" face="sans-serif">Kostya Serebryany <<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">To: </font><font size="1" face="sans-serif">Samuel F Antao/Watson/IBM@IBMUS</font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Cc: </font><font size="1" face="sans-serif">Commit Messages and Patches for LLVM <<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a>></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Date: </font><font size="1" face="sans-serif">09/15/2014 04:51 PM</font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Subject: </font><font size="1" face="sans-serif">Re: [PATCH][compiler-rt] Fix global constructor warning in sanitizer.</font><br>
</p><hr width="100%" size="2" align="left" noshade style="color:rgb(128,145,165)"><div><div class="h5"><br>
<br>
<br>
<font size="3" face="serif">LGTM</font><br>
<br>
<font size="3" face="serif">On Wed, Sep 10, 2014 at 4:32 PM, Samuel F Antao <</font><a href="mailto:sfantao@us.ibm.com" target="_blank"><font size="3" color="#0000FF" face="serif"><u>sfantao@us.ibm.com</u></font></a><font size="3" face="serif">> wrote:</font>
<ul style="padding-left:9pt"><font size="3" face="sans-serif">Hi all,</font><font size="3" face="serif"><br>
</font><font size="3" face="sans-serif"><br>
If EV_VERSION > 0x010000 is not true, the compilation of sanitizer_platform_limits_posix.cc returns the warnings:</font><font size="3" face="serif"><br>
</font><font size="3" face="sans-serif"><br>
.../projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:757:12: warning: declaration requires a global constructor [-Wglobal-constructors]<br>
unsigned IOCTL_EVIOCGKEYCODE_V2 = IOCTL_NOT_PRESENT;<br>
^ ~~~~~~~~~~~~~~~~~<br>
.../projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:758:12: warning: declaration requires a global constructor [-Wglobal-constructors]<br>
unsigned IOCTL_EVIOCGPROP = IOCTL_NOT_PRESENT;<br>
^ ~~~~~~~~~~~~~~~~~<br>
.../projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:759:12: warning: declaration requires a global constructor [-Wglobal-constructors]<br>
unsigned IOCTL_EVIOCSKEYCODE_V2 = IOCTL_NOT_PRESENT;<br>
^ ~~~~~~~~~~~~~~~~~<br>
3 warnings generated.</font><font size="3" face="serif"><br>
</font><font size="3" face="sans-serif"><br>
This patch fixes the issue by adding the const attribute to IOCTL_NOT_PRESENT.</font><font size="3" face="serif"><br>
</font><font size="3" face="sans-serif"><br>
The modified files are the following:<br>
sanitizer_platform_limits_posix.cc<br>
sanitizer_platform_limits_posix.h</font><font size="3" face="serif"><br>
<br>
</font><font size="3" face="sans-serif"><br>
Thanks,<br>
Sam</font><font size="3" face="serif"><br>
</font><font size="3" face="serif"><i><br>
(See attached file: crt_ioctl_not_present_fix.patch)</i></font><br>
<font size="3" face="serif"><br>
_______________________________________________<br>
llvm-commits mailing list</font><font size="3" color="#0000FF" face="serif"><u><br>
</u></font><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank"><font size="3" color="#0000FF" face="serif"><u>llvm-commits@cs.uiuc.edu</u></font></a><font size="3" color="#0000FF" face="serif"><u><br>
</u></font><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank"><font size="3" color="#0000FF" face="serif"><u>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</u></font></a><font size="3" face="serif"><br>
</font></ul>
<br>
</div></div><p></p></div>
</blockquote></div><br></div></div>