<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Sep 15, 2014 at 8:21 PM, Brad Smith <span dir="ltr"><<a href="mailto:brad@comstyle.com" target="_blank">brad@comstyle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 15/09/14 1:18 PM, Rafael Espíndola wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Has this been approved?<br>
</blockquote>
<br>
Yes.<div class="HOEnZb"><div class="h5"><br></div></div></blockquote><div><br></div><div>After I objected?</div><div><br></div><div>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 11 September 2014 13:40, Brad Smith <<a href="mailto:brad@comstyle.com" target="_blank">brad@comstyle.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: brad<br>
Date: Thu Sep 11 12:40:51 2014<br>
New Revision: 217611<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=217611&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=217611&view=rev</a><br>
Log:<br>
Provide an implementation of getNoopForMachoTarget for SPARC.<br>
<br>
Added:<br>
     llvm/trunk/test/CodeGen/SPARC/<u></u>empty-functions.ll<br>
Modified:<br>
     llvm/trunk/lib/Target/Sparc/<u></u>SparcInstrInfo.cpp<br>
     llvm/trunk/lib/Target/Sparc/<u></u>SparcInstrInfo.h<br>
<br>
Modified: llvm/trunk/lib/Target/Sparc/<u></u>SparcInstrInfo.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Sparc/SparcInstrInfo.cpp?rev=217611&r1=217610&r2=217611&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>Sparc/SparcInstrInfo.cpp?rev=<u></u>217611&r1=217610&r2=217611&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Target/Sparc/<u></u>SparcInstrInfo.cpp (original)<br>
+++ llvm/trunk/lib/Target/Sparc/<u></u>SparcInstrInfo.cpp Thu Sep 11 12:40:51 2014<br>
@@ -37,6 +37,11 @@ SparcInstrInfo::<u></u>SparcInstrInfo(SparcSubt<br>
      RI(ST), Subtarget(ST) {<br>
  }<br>
<br>
+/// getNoopForMachoTarget - Return the noop instruction to use for a noop.<br>
+void SparcInstrInfo::<u></u>getNoopForMachoTarget(MCInst &NopInst) const {<br>
+  NopInst.setOpcode(SP::NOP);<br>
+}<br>
+<br>
  /// isLoadFromStackSlot - If the specified machine instruction is a direct<br>
  /// load from a stack slot, return the virtual or physical register number of<br>
  /// the destination along with the FrameIndex of the loaded stack slot.  If<br>
<br>
Modified: llvm/trunk/lib/Target/Sparc/<u></u>SparcInstrInfo.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Sparc/SparcInstrInfo.h?rev=217611&r1=217610&r2=217611&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>Sparc/SparcInstrInfo.h?rev=<u></u>217611&r1=217610&r2=217611&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Target/Sparc/<u></u>SparcInstrInfo.h (original)<br>
+++ llvm/trunk/lib/Target/Sparc/<u></u>SparcInstrInfo.h Thu Sep 11 12:40:51 2014<br>
@@ -93,6 +93,8 @@ public:<br>
                              const TargetRegisterInfo *TRI) const override;<br>
<br>
    unsigned getGlobalBaseReg(<u></u>MachineFunction *MF) const;<br>
+<br>
+  void getNoopForMachoTarget(MCInst &NopInst) const override;<br>
  };<br>
<br>
  }<br>
<br>
Added: llvm/trunk/test/CodeGen/SPARC/<u></u>empty-functions.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/SPARC/empty-functions.ll?rev=217611&view=auto" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/<u></u>CodeGen/SPARC/empty-functions.<u></u>ll?rev=217611&view=auto</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/CodeGen/SPARC/<u></u>empty-functions.ll (added)<br>
+++ llvm/trunk/test/CodeGen/SPARC/<u></u>empty-functions.ll Thu Sep 11 12:40:51 2014<br>
@@ -0,0 +1,8 @@<br>
+; RUN: llc < %s -mtriple=sparc-unknown-openbsd -disable-fp-elim | FileCheck -check-prefix=CHECK-FP-LABEL %s<br>
+<br>
+define void @func() {<br>
+entry:<br>
+  unreachable<br>
+}<br>
+; CHECK-FP-LABEL:      {{_?}}func:<br>
+; CHECK-FP-LABEL: nop {{[;!]}} avoids zero-length function<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote>
<br>
</blockquote>
<br>
<br></div></div><span class="HOEnZb"><font color="#888888">
-- <br>
This message has been scanned for viruses and<br>
dangerous content by MailScanner, and is<br>
believed to be clean.</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>