<div dir="ltr">LGTM</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 10, 2014 at 4:32 PM, Samuel F Antao <span dir="ltr"><<a href="mailto:sfantao@us.ibm.com" target="_blank">sfantao@us.ibm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><div>
<p><font face="sans-serif">Hi all,</font><br>
<br>
<font face="sans-serif">If EV_VERSION > 0x010000 is not true, the compilation of sanitizer_platform_limits_posix.cc returns the warnings:</font><br>
<br>
<font face="sans-serif">.../projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:757:12: warning: declaration requires a global constructor [-Wglobal-constructors]</font><br>
<font face="sans-serif">  unsigned IOCTL_EVIOCGKEYCODE_V2 = IOCTL_NOT_PRESENT;</font><br>
<font face="sans-serif">           ^                        ~~~~~~~~~~~~~~~~~</font><br>
<font face="sans-serif">.../projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:758:12: warning: declaration requires a global constructor [-Wglobal-constructors]</font><br>
<font face="sans-serif">  unsigned IOCTL_EVIOCGPROP = IOCTL_NOT_PRESENT;</font><br>
<font face="sans-serif">           ^                  ~~~~~~~~~~~~~~~~~</font><br>
<font face="sans-serif">.../projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc:759:12: warning: declaration requires a global constructor [-Wglobal-constructors]</font><br>
<font face="sans-serif">  unsigned IOCTL_EVIOCSKEYCODE_V2 = IOCTL_NOT_PRESENT;</font><br>
<font face="sans-serif">           ^                        ~~~~~~~~~~~~~~~~~</font><br>
<font face="sans-serif">3 warnings generated.</font><br>
<br>
<font face="sans-serif">This patch fixes the issue by adding the const attribute to IOCTL_NOT_PRESENT.</font><br>
<br>
<font face="sans-serif">The modified files are the following:</font><br>
<font face="sans-serif">sanitizer_platform_limits_posix.cc</font><br>
<font face="sans-serif">sanitizer_platform_limits_posix.h</font><br>
<br>
<br>
<font face="sans-serif">Thanks,</font><br>
<font face="sans-serif">Sam</font><br>
<br>
<i>(See attached file: crt_ioctl_not_present_fix.patch)</i></p></div>
</div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>