<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 15 Sep 2014, at 12:07, Chandler Carruth <<a href="mailto:chandlerc@google.com" class="">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="gmail_extra" style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="gmail_quote"><br class="Apple-interchange-newline">On Mon, Sep 15, 2014 at 2:58 AM, Frédéric Riss<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:friss@apple.com" target="_blank" class="">friss@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><span class=""><blockquote type="cite" class=""><div class="">On 15 Sep 2014, at 11:51, Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank" class="">chandlerc@google.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Sep 15, 2014 at 12:50 AM, Frederic Riss<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:friss@apple.com" target="_blank" class="">friss@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="overflow: hidden;" class="">+/// Base class for all DWARFUnitSection classes. This provides the<br class="">+/// functionality common to all unit types.<br class="">+class DWARFUnitSectionBase {<br class="">+public:<br class="">+ /// Returns the Unit that contains the given section offset in the<br class="">+ /// same section this Unit originated from.<br class="">+ virtual DWARFUnit *getUnitForOffset(uint32_t Offset) const = 0;<br class=""></div></blockquote><div class=""><br class=""></div><div class="">This, through every instantiation of the below template:</div><div class=""> </div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="overflow: hidden;" class="">+};<br class="">+<br class="">+/// Concrete instance of DWARFUnitSection, specialized for one Unit type.<br class="">+template<typename UnitType><br class="">+class DWARFUnitSection : public SmallVector<std::unique_ptr<UnitType>, 1>,<br class="">+ public DWARFUnitSectionBase {</div></blockquote></div><br class="">Is causing *massive* spews of warnings. =/</div></div></div></blockquote><div class=""><br class=""></div></span><div class="">Sorry about that, I’m not seeing anything here… what kind of warnings? There was an ambiguous type aliasing issue that I corrected in r217751 (only diagnosed by GCC btw).</div></blockquote></div><br class="">../lib/DebugInfo/DWARFUnit.h:33:7: warning: 'llvm::DWARFUnitSectionBase' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]<br class=""></div><div class="gmail_extra" style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class=""></div><div class="gmail_extra" style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Not sure if I have a busted compiler, but I'm self hosting with Clang...</div></div></blockquote></div><br class=""><div class="">This is obviously true, but I don’t see it with my system clang version, and I didn’t see it on any on the bots I looked at. Maybe it will show up in later bootstrap builds that will use trunk clang.</div><div class=""><br class=""></div><div class="">As I need pre-commit review to get the fix in, do you want me to revert the change now? I’ll submit the code removing the inheritance later today, but I can’t presume of the review time.</div><div class=""><br class=""></div><div class="">Fred</div></body></html>