<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Sep 7, 2014 at 7:47 PM, Eric Christopher <span dir="ltr"><<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Might want to comment the limitation above the conditional.</div></blockquote><div><br></div><div>Certainly - r217842</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><span class=""><font color="#888888"><div><br></div><div>-eric</div></font></span></div><div class=""><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Sep 7, 2014 at 10:31 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: dblaikie<br>
Date: Sun Sep  7 12:31:42 2014<br>
New Revision: 217338<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=217338&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=217338&view=rev</a><br>
Log:<br>
DebugInfo: Do not use DW_FORM_GNU_addr_index in skeleton CUs, GDB 7.8 errors on this.<br>
<br>
It's probably not a huge deal to not do this - if we could, maybe the<br>
address could be reused by a subprogram low_pc and avoid an extra<br>
relocation, but it's just one per CU at best.<br>
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp<br>
    llvm/trunk/test/DebugInfo/X86/cu-ranges.ll<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp?rev=217338&r1=217337&r2=217338&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp?rev=217338&r1=217337&r2=217338&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp Sun Sep  7 12:31:42 2014<br>
@@ -288,7 +288,7 @@ void DwarfUnit::addSectionOffset(DIE &Di<br>
 void DwarfCompileUnit::addLabelAddress(DIE &Die, dwarf::Attribute Attribute,<br>
                                        const MCSymbol *Label) {<br>
<br>
-  if (!DD->useSplitDwarf())<br>
+  if (!DD->useSplitDwarf() || !Skeleton)<br>
     return addLocalLabelAddress(Die, Attribute, Label);<br>
<br>
   if (Label)<br>
<br>
Modified: llvm/trunk/test/DebugInfo/X86/cu-ranges.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/cu-ranges.ll?rev=217338&r1=217337&r2=217338&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/cu-ranges.ll?rev=217338&r1=217337&r2=217338&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/DebugInfo/X86/cu-ranges.ll (original)<br>
+++ llvm/trunk/test/DebugInfo/X86/cu-ranges.ll Sun Sep  7 12:31:42 2014<br>
@@ -1,9 +1,9 @@<br>
 ; RUN: llc -split-dwarf=Enable -O0 %s -function-sections -mtriple=x86_64-unknown-linux-gnu -filetype=obj -o %t<br>
-; RUN: llvm-dwarfdump -debug-dump=all %t | FileCheck --check-prefix=FUNCTION-SECTIONS %s<br>
+; RUN: llvm-dwarfdump -debug-dump=abbrev %t | FileCheck --check-prefix=FUNCTION-SECTIONS %s<br>
 ; RUN: llvm-readobj --relocations %t | FileCheck --check-prefix=FUNCTION-SECTIONS-RELOCS %s<br>
<br>
 ; RUN: llc -split-dwarf=Enable -O0 %s -mtriple=x86_64-unknown-linux-gnu -filetype=obj -o %t<br>
-; RUN: llvm-dwarfdump -debug-dump=all %t | FileCheck --check-prefix=NO-FUNCTION-SECTIONS %s<br>
+; RUN: llvm-dwarfdump -debug-dump=abbrev %t | FileCheck --check-prefix=NO-FUNCTION-SECTIONS %s<br>
<br>
 ; From:<br>
 ; int foo (int a) {<br>
@@ -21,6 +21,8 @@<br>
<br>
 ; Without function sections enabled make sure that we have no DW_AT_ranges attribute.<br>
 ; NO-FUNCTION-SECTIONS-NOT: DW_AT_ranges<br>
+; NO-FUNCTION-SECTIONS: DW_AT_low_pc DW_FORM_addr<br>
+; NO-FUNCTION-SECTIONS-NOT: DW_AT_ranges<br>
<br>
 ; Function Attrs: nounwind uwtable<br>
 define i32 @foo(i32 %a) #0 {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div></div>