<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 15 Sep 2014, at 12:26, Chandler Carruth <<a href="mailto:chandlerc@google.com" class="">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Mon, Sep 15, 2014 at 3:23 AM, Frédéric Riss <span dir="ltr" class=""><<a href="mailto:friss@apple.com" target="_blank" class="">friss@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">This is obviously true, but I don’t see it with my system clang version, and I didn’t see it on any on the bots I looked at. Maybe it will show up in later bootstrap builds that will use trunk clang.</div><div class=""><br class=""></div><div class="">As I need pre-commit review to get the fix in, do you want me to revert the change now?</div></blockquote><div class=""><br class=""></div><div class="">Whaaa? No no, you don't need pre-commit review to fix a problem pointed out by a warning. =D Please just commit the fix if you have it. If not, I'll commit it shortly so my builds are tidied up.</div></div></div></div></div></blockquote><div><br class=""></div><div>Oh, I wasn’t talking about just your warning. I was talking about the inheritance removal which is a bit bigger. For your warning, I can add an empty virtual destructor to the base class, and hope it fixes the issue for you. I’ll try to reproduce it first.</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class=""> I’ll submit the code removing the inheritance later today, but I can’t presume of the review time.</div></blockquote></div><br class=""><br class=""></div></div>
</div></blockquote></div><br class=""></body></html>