<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><span style="font-family: Menlo;">Thanks, Chad! </span>Addressed in <span style="font-family: Menlo;">Committed revision 217538</span><div><font face="Menlo"><br></font></div><div><font face="Menlo">-Gerolf</font></div><div><font face="Menlo"><br></font></div><div><div><div>On Sep 10, 2014, at 12:53 PM, Chad Rosier <<a href="mailto:mcrosier@codeaurora.org">mcrosier@codeaurora.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Assuming my minor nit is addressed, LGTM.<br><br>================<br>Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:235<br>@@ -230,2 +234,3 @@<br> if (OptLevel > 1) {<br>- MPM.add(createMergedLoadStoreMotionPass()); // Merge load/stores in diamond<br>+ if (EnableMLSM)<br>+ MPM.add(<br>----------------<br>I'd prefer something like:<br><br>if (EnableMLSM) // Merge load/stores in diamond<br> MPM.add(createMergedLoadStoreMotionPass());<br><br>or maybe<br><br>if (EnableMLSM)<br> MPM.add(createMergedLoadStoreMotionPass()); // Merge ld/st in diamond<br><br><a href="http://reviews.llvm.org/D5299">http://reviews.llvm.org/D5299</a><br><br><br></blockquote></div><br></div></body></html>