<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Sorry, didn’t see that commit. Thanks :D<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 8, 2014, at 3:18 PM, Rui Ueyama <<a href="mailto:ruiu@google.com" class="">ruiu@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">On Mon, Sep 8, 2014 at 3:17 PM, Juergen Ributzka <span dir="ltr" class=""><<a href="mailto:juergen@apple.com" target="_blank" class="">juergen@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><br class=""><div class=""><div class=""><div class="h5"><blockquote type="cite" class=""><div class="">On Sep 6, 2014, at 6:44 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank" class="">chandlerc@google.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class=""><div class="gmail_extra"><div class="gmail_quote"><br class="">On Sat, Sep 6, 2014 at 6:23 PM, Rui Ueyama<span class=""> </span><span dir="ltr" class=""><<a href="mailto:ruiu@google.com" target="_blank" class="">ruiu@google.com</a>></span><span class=""> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="overflow:hidden" class="">Author: ruiu<br class="">Date: Sat Sep 6 20:23:16 2014<br class="">New Revision: 217324<br class=""><br class="">URL:<span class=""> </span><a href="http://llvm.org/viewvc/llvm-project?rev=217324&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=217324&view=rev</a><br class="">Log:<br class="">Remove dead code.<br class=""><br class="">Modified:<br class=""> <span class=""> </span>lld/trunk/include/lld/Core/File.h<br class=""> <span class=""> </span>lld/trunk/lib/Core/File.cpp<br class=""><br class="">Modified: lld/trunk/include/lld/Core/File.h<br class="">URL:<span class=""> </span><a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/File.h?rev=217324&r1=217323&r2=217324&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/File.h?rev=217324&r1=217323&r2=217324&view=diff</a><br class="">==============================================================================<br class="">--- lld/trunk/include/lld/Core/File.h (original)<br class="">+++ lld/trunk/include/lld/Core/File.h Sat Sep 6 20:23:16 2014<br class="">@@ -39,7 +39,7 @@ class LinkingContext;<br class=""> /// are destroyed when the File object is destroyed.<br class=""> class File {<br class=""> public:<br class="">- virtual ~File();<br class="">+ virtual ~File() {}</div></blockquote></div><br class="">This removes the initial out-of-line virtual function which provides the key function for the class allowing its code to be emitted in a single translation unit. Maybe this should be kept?</div></div></div></blockquote><div class=""><br class=""></div></div></div>+1</div></div></blockquote><div class=""> </div><div class="">Done in r217392.</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><span class=""><div class=""><blockquote type="cite" class=""><div class=""><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="">_______________________________________________</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class=""><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="">llvm-commits mailing list</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class=""><a href="mailto:llvm-commits@cs.uiuc.edu" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class=""><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br class=""></span></div></blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></div></body></html>