<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Sep 6, 2014 at 6:23 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div id=":21q" class="a3s" style="overflow:hidden">Author: ruiu<br>
Date: Sat Sep  6 20:23:16 2014<br>
New Revision: 217324<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=217324&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=217324&view=rev</a><br>
Log:<br>
Remove dead code.<br>
<br>
Modified:<br>
    lld/trunk/include/lld/Core/File.h<br>
    lld/trunk/lib/Core/File.cpp<br>
<br>
Modified: lld/trunk/include/lld/Core/File.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/File.h?rev=217324&r1=217323&r2=217324&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/File.h?rev=217324&r1=217323&r2=217324&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/include/lld/Core/File.h (original)<br>
+++ lld/trunk/include/lld/Core/File.h Sat Sep  6 20:23:16 2014<br>
@@ -39,7 +39,7 @@ class LinkingContext;<br>
 /// are destroyed when the File object is destroyed.<br>
 class File {<br>
 public:<br>
-  virtual ~File();<br>
+  virtual ~File() {}</div></blockquote></div><br>This removes the initial out-of-line virtual function which provides the key function for the class allowing its code to be emitted in a single translation unit. Maybe this should be kept?</div></div>