<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 05 Sep 2014, at 00:28, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Please go ahead & commit the decl/call_line portion of this (I'll take your word for it that these seem like the only ones that should be printed as decimal, the rest as hex - and if we see other cases we can figure it out at that point) & then rebase this patch.<br class=""></div></div></blockquote><div><br class=""></div><div>This is r217232, thanks.</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">The realpath piece of this is particularly interesting - I don't know what that API is, where it comes from (why it might not always be available), etc. Also, not sure it makes sense to canonicalize the paths based on the actual filesystem, rather than just rendering what's in the line table... maybe some examples would help me understand better. (is that codepath tested? How do we test it on machines that don't have realpath?)</div></div></blockquote><div><br class=""></div><div>I knew this bit would attract some interest. Regarding the availability, there is a configure test, thus I suppose it’s not available everywhere (Windows maybe?). It really helps the legibility when you have projects with deep, recursive, build trees. For example, instead of </div><div><br class=""></div><div><div style="margin: 0px;" class=""><div style="margin: 0px;" class="">"/tmp/build/some/project/with/very/deep/source/tree/../../../../../../../../some/project/with/very/deep/source/tree/foo.c”</div><div style="margin: 0px;" class=""><br class=""></div><div style="margin: 0px;" class="">you get</div><div style="margin: 0px;" class=""><br class=""></div><div style="margin: 0px;" class="">“/tmp/some/project/with/very/deep/source/tree/foo.c"</div></div></div><div><br class=""></div><div>Note however that this part is optional and could be discussed separately. Another motivation for me to have this in llvm-dwarfdump is that Darwin’s dwarfdump does this transformation. You might not care, but having nearly identical outputs allows me to cross-verify the 2 implementations on a very large set of archived binaries. I think this gets us more coverage that any LIT tests that we might add. I understand however that this is in no way a strong argument for getting it into the tree, I just thought I’d mention the validation I do on the side.</div><div><br class=""></div><div>Fred</div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Sep 4, 2014 at 2:37 PM, Frederic Riss <span dir="ltr" class=""><<a href="mailto:friss@apple.com" target="_blank" class="">friss@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Sorry for the spam. I'm still learning to use arcanist, and I must say at this point it's more a burden that a help... This latest revision is the result of a small series of 3 commits that should be easy enough to distinguish. They aren't really intermingled except for the test updates.<br class="">
The first just prints the line numbers in decimal and updates the tests.<br class="">
The second moves some static helpers of DWARFContext.cpp into equivalent methods of LineTable. There should be no functional change though.<br class="">
The third one uses the newly exposed method to find and print full names for files referenced by DW_AT_(decl|call)_file.<br class="">
<br class="">
<a href="http://reviews.llvm.org/D5192" target="_blank" class="">http://reviews.llvm.org/D5192</a><br class="">
<br class="">
<br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>