<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 5, 2014 at 3:26 PM, Eric Christopher <span dir="ltr"><<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">... I know you'll kick me for this, but we should add an alias for -gmlt to -gline-tables-only. :)</div></blockquote><div><br></div><div>Pretty sure I already did... probably.<br><br><a href="http://llvm.org/viewvc/llvm-project?rev=203603&view=rev">http://llvm.org/viewvc/llvm-project?rev=203603&view=rev</a><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><span><font color="#888888"><div><br></div><div>-eric</div></font></span></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 5, 2014 at 3:05 PM, Alexey Samsonov <span dir="ltr"><<a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: samsonov<br>
Date: Fri Sep 5 17:05:32 2014<br>
New Revision: 217284<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=217284&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=217284&view=rev</a><br>
Log:<br>
Use "-gline-tables-only" instead of "-g" in sanitizer test suites.<br>
<br>
We are interested in verifying that -gline-tables-only provides enough<br>
debug information for verbose error reports and symbolized stack traces.<br>
<br>
Modified:<br>
compiler-rt/trunk/test/asan/lit.cfg<br>
compiler-rt/trunk/test/lit.common.cfg<br>
compiler-rt/trunk/test/lsan/lit.common.cfg<br>
compiler-rt/trunk/test/msan/lit.cfg<br>
compiler-rt/trunk/test/sanitizer_common/TestCases/print-stack-trace.cc<br>
compiler-rt/trunk/test/sanitizer_common/lit.common.cfg<br>
compiler-rt/trunk/test/tsan/lit.cfg<br>
<br>
Modified: compiler-rt/trunk/test/asan/lit.cfg<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/lit.cfg?rev=217284&r1=217283&r2=217284&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/lit.cfg?rev=217284&r1=217283&r2=217284&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/asan/lit.cfg (original)<br>
+++ compiler-rt/trunk/test/asan/lit.cfg Fri Sep 5 17:05:32 2014<br>
@@ -38,11 +38,11 @@ if config.compiler_id == 'GNU' and confi<br>
# FIXME: Review the set of required flags and check if it can be reduced.<br>
target_cflags = [get_required_attr(config, "target_cflags")] + extra_linkflags<br>
target_cxxflags = config.cxx_mode_flags + target_cflags<br>
-clang_asan_static_cflags = ["-fsanitize=address",<br>
+clang_asan_static_cflags = (["-fsanitize=address",<br>
"-mno-omit-leaf-frame-pointer",<br>
"-fno-omit-frame-pointer",<br>
- "-fno-optimize-sibling-calls",<br>
- "-g"] + target_cflags<br>
+ "-fno-optimize-sibling-calls"] +<br>
+ config.debug_info_flags + target_cflags)<br>
clang_asan_static_cxxflags = config.cxx_mode_flags + clang_asan_static_cflags<br>
<br>
if config.asan_dynamic:<br>
<br>
Modified: compiler-rt/trunk/test/lit.common.cfg<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/lit.common.cfg?rev=217284&r1=217283&r2=217284&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/lit.common.cfg?rev=217284&r1=217283&r2=217284&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/lit.common.cfg (original)<br>
+++ compiler-rt/trunk/test/lit.common.cfg Fri Sep 5 17:05:32 2014<br>
@@ -25,8 +25,12 @@ if compiler_id == "Clang":<br>
config.cxx_mode_flags = ["--driver-mode=g++"]<br>
else:<br>
config.cxx_mode_flags = []<br>
+ # We assume that sanitizers should provide good enough error<br>
+ # reports and stack traces even with minimal debug info.<br>
+ config.debug_info_flags = ["-gline-tables-only"]<br>
elif compiler_id == 'GNU':<br>
config.cxx_mode_flags = ["-x c++"]<br>
+ config.debug_info_flags = ["-g"]<br>
else:<br>
lit_config.fatal("Unsupported compiler id: %r" % compiler_id)<br>
# Add compiler ID to the list of available features.<br>
<br>
Modified: compiler-rt/trunk/test/lsan/lit.common.cfg<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/lsan/lit.common.cfg?rev=217284&r1=217283&r2=217284&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/lsan/lit.common.cfg?rev=217284&r1=217283&r2=217284&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/lsan/lit.common.cfg (original)<br>
+++ compiler-rt/trunk/test/lsan/lit.common.cfg Fri Sep 5 17:05:32 2014<br>
@@ -29,7 +29,7 @@ elif lsan_lit_test_mode == "AddressSanit<br>
else:<br>
lit_config.fatal("Unknown LSan test mode: %r" % lsan_lit_test_mode)<br>
<br>
-clang_cflags = ["-g", "-O0", "-m64"]<br>
+clang_cflags = ["-O0", "-m64"] + config.debug_info_flags<br>
clang_cxxflags = config.cxx_mode_flags + clang_cflags<br>
clang_lsan_cflags = clang_cflags + lsan_cflags<br>
clang_lsan_cxxflags = clang_cxxflags + lsan_cflags<br>
<br>
Modified: compiler-rt/trunk/test/msan/lit.cfg<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/msan/lit.cfg?rev=217284&r1=217283&r2=217284&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/msan/lit.cfg?rev=217284&r1=217283&r2=217284&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/msan/lit.cfg (original)<br>
+++ compiler-rt/trunk/test/msan/lit.cfg Fri Sep 5 17:05:32 2014<br>
@@ -13,8 +13,7 @@ clang_msan_cflags = ["-fsanitize=memory"<br>
"-mno-omit-leaf-frame-pointer",<br>
"-fno-omit-frame-pointer",<br>
"-fno-optimize-sibling-calls",<br>
- "-g",<br>
- "-m64"]<br>
+ "-m64"] + config.debug_info_flags<br>
clang_msan_cxxflags = config.cxx_mode_flags + clang_msan_cflags<br>
<br>
def build_invocation(compile_flags):<br>
<br>
Modified: compiler-rt/trunk/test/sanitizer_common/TestCases/print-stack-trace.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/print-stack-trace.cc?rev=217284&r1=217283&r2=217284&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/print-stack-trace.cc?rev=217284&r1=217283&r2=217284&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/sanitizer_common/TestCases/print-stack-trace.cc (original)<br>
+++ compiler-rt/trunk/test/sanitizer_common/TestCases/print-stack-trace.cc Fri Sep 5 17:05:32 2014<br>
@@ -16,5 +16,5 @@ int main() {<br>
return 0;<br>
}<br>
// CHECK: {{ #0 0x.* in __sanitizer_print_stack_trace}}<br>
-// CHECK: {{ #1 0x.* in FooBarBaz\(\) .*print-stack-trace.cc:11}}<br>
+// CHECK: {{ #1 0x.* in FooBarBaz(\(\))? .*print-stack-trace.cc:11}}<br>
// CHECK: {{ #2 0x.* in main.*print-stack-trace.cc:15}}<br>
<br>
Modified: compiler-rt/trunk/test/sanitizer_common/lit.common.cfg<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/lit.common.cfg?rev=217284&r1=217283&r2=217284&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/lit.common.cfg?rev=217284&r1=217283&r2=217284&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/sanitizer_common/lit.common.cfg (original)<br>
+++ compiler-rt/trunk/test/sanitizer_common/lit.common.cfg Fri Sep 5 17:05:32 2014<br>
@@ -18,7 +18,7 @@ else:<br>
<br>
config.available_features.add(config.tool_name)<br>
<br>
-clang_cflags = ["-g"] + tool_cflags + [config.target_cflags]<br>
+clang_cflags = config.debug_info_flags + tool_cflags + [config.target_cflags]<br>
clang_cxxflags = config.cxx_mode_flags + clang_cflags<br>
<br>
def build_invocation(compile_flags):<br>
<br>
Modified: compiler-rt/trunk/test/tsan/lit.cfg<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/lit.cfg?rev=217284&r1=217283&r2=217284&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/lit.cfg?rev=217284&r1=217283&r2=217284&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/tsan/lit.cfg (original)<br>
+++ compiler-rt/trunk/test/tsan/lit.cfg Fri Sep 5 17:05:32 2014<br>
@@ -29,11 +29,9 @@ else:<br>
extra_cflags = []<br>
<br>
# Setup default compiler flags used with -fsanitize=thread option.<br>
-# FIXME: Review the set of required flags and check if it can be reduced.<br>
clang_tsan_cflags = ["-fsanitize=thread",<br>
- "-g",<br>
"-Wall",<br>
- "-m64"] + extra_cflags<br>
+ "-m64"] + config.debug_info_flags + extra_cflags<br>
clang_tsan_cxxflags = config.cxx_mode_flags + clang_tsan_cflags<br>
# Add additional flags if we're using instrumented libc++.<br>
if config.has_libcxx:<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>