<div dir="ltr">(Replying to all so you only get one copy of this)<div><br></div><div>As a note when you revert please put the svn revision number rather than git revision :)</div><div><br></div><div>Thanks!</div><div><br></div>
<div>-eric</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 4, 2014 at 11:55 AM, Frederic Riss <span dir="ltr"><<a href="mailto:friss@apple.com" target="_blank">friss@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: friss<br>
Date: Thu Sep  4 13:55:46 2014<br>
New Revision: 217183<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=217183&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=217183&view=rev</a><br>
Log:<br>
Revert "[dwarfdump] Add missing DW_LANG_Mips_Assembler case to LanguageString()"<br>
<br>
This reverts commit 93c7e6161e1adbd2c7ac81fa081823183035cb64.<br>
<br>
This commit got approved first, but was dependant on another one going in (The one pretty printing attribute values). I'll reapply when the other one is in.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Support/Dwarf.cpp<br>
    llvm/trunk/test/DebugInfo/2010-03-19-DbgDeclare.ll<br>
    llvm/trunk/test/MC/MachO/gen-dwarf.s<br>
<br>
Modified: llvm/trunk/lib/Support/Dwarf.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Dwarf.cpp?rev=217183&r1=217182&r2=217183&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Dwarf.cpp?rev=217183&r1=217182&r2=217183&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Support/Dwarf.cpp (original)<br>
+++ llvm/trunk/lib/Support/Dwarf.cpp Thu Sep  4 13:55:46 2014<br>
@@ -598,7 +598,6 @@ const char *llvm::dwarf::LanguageString(<br>
   case DW_LANG_C_plus_plus_11:           return "DW_LANG_C_plus_plus_11";<br>
   case DW_LANG_OCaml:                    return "DW_LANG_OCaml";<br>
   case DW_LANG_lo_user:                  return "DW_LANG_lo_user";<br>
-  case DW_LANG_Mips_Assembler:           return "DW_LANG_Mips_Assembler";<br>
   case DW_LANG_hi_user:                  return "DW_LANG_hi_user";<br>
   }<br>
   return nullptr;<br>
<br>
Modified: llvm/trunk/test/DebugInfo/2010-03-19-DbgDeclare.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/2010-03-19-DbgDeclare.ll?rev=217183&r1=217182&r2=217183&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/2010-03-19-DbgDeclare.ll?rev=217183&r1=217182&r2=217183&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/test/DebugInfo/2010-03-19-DbgDeclare.ll (original)<br>
+++ llvm/trunk/test/DebugInfo/2010-03-19-DbgDeclare.ll Thu Sep  4 13:55:46 2014<br>
@@ -1,6 +1,6 @@<br>
 ; RUN: opt < %s -verify -S | FileCheck %s<br>
<br>
-; CHECK: [DW_LANG_Mips_Assembler]<br>
+; CHECK: lang 0x8001<br>
<br>
 define void @Foo(i32 %a, i32 %b) {<br>
 entry:<br>
<br>
Modified: llvm/trunk/test/MC/MachO/gen-dwarf.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/MachO/gen-dwarf.s?rev=217183&r1=217182&r2=217183&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/MachO/gen-dwarf.s?rev=217183&r1=217182&r2=217183&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/test/MC/MachO/gen-dwarf.s (original)<br>
+++ llvm/trunk/test/MC/MachO/gen-dwarf.s Thu Sep  4 13:55:46 2014<br>
@@ -46,7 +46,7 @@ _x:   .long 1<br>
 // CHECK:    DW_AT_name [DW_FORM_string]<br>
 // We don't check the DW_AT_comp_dir which is the current working directory<br>
 // CHECK:    DW_AT_producer [DW_FORM_string]   ("llvm-mc (based on {{.*}})")<br>
-// CHECK:    DW_AT_language [DW_FORM_data2]    (DW_LANG_Mips_Assembler)<br>
+// CHECK:    DW_AT_language [DW_FORM_data2]    (0x8001)<br>
<br>
 // CHECK:    DW_TAG_label [2] *<br>
 // CHECK:      DW_AT_name [DW_FORM_string]     ("bar")<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>