<p dir="ltr"><br>
On Sep 4, 2014 12:07 PM, "Frederic Riss" <<a href="mailto:friss@apple.com">friss@apple.com</a>> wrote:<br>
><br>
> Author: friss<br>
> Date: Thu Sep  4 13:55:46 2014<br>
> New Revision: 217183<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=217183&view=rev">http://llvm.org/viewvc/llvm-project?rev=217183&view=rev</a><br>
> Log:<br>
> Revert "[dwarfdump] Add missing DW_LANG_Mips_Assembler case to LanguageString()"<br>
><br>
> This reverts commit 93c7e6161e1adbd2c7ac81fa081823183035cb64.</p>
<p dir="ltr">It'd helpful to mention the svn revision number rather than git hash. We have a script to help with this (llvm/utils/git-svn/git-svnrevert)</p>
<p dir="ltr">><br>
> This commit got approved first, but was dependant on another one going in (The one pretty printing attribute values). I'll reapply when the other one is in.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Support/Dwarf.cpp<br>
>     llvm/trunk/test/DebugInfo/2010-03-19-DbgDeclare.ll<br>
>     llvm/trunk/test/MC/MachO/gen-dwarf.s<br>
><br>
> Modified: llvm/trunk/lib/Support/Dwarf.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Dwarf.cpp?rev=217183&r1=217182&r2=217183&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Dwarf.cpp?rev=217183&r1=217182&r2=217183&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/lib/Support/Dwarf.cpp (original)<br>
> +++ llvm/trunk/lib/Support/Dwarf.cpp Thu Sep  4 13:55:46 2014<br>
> @@ -598,7 +598,6 @@ const char *llvm::dwarf::LanguageString(<br>
>    case DW_LANG_C_plus_plus_11:           return "DW_LANG_C_plus_plus_11";<br>
>    case DW_LANG_OCaml:                    return "DW_LANG_OCaml";<br>
>    case DW_LANG_lo_user:                  return "DW_LANG_lo_user";<br>
> -  case DW_LANG_Mips_Assembler:           return "DW_LANG_Mips_Assembler";<br>
>    case DW_LANG_hi_user:                  return "DW_LANG_hi_user";<br>
>    }<br>
>    return nullptr;<br>
><br>
> Modified: llvm/trunk/test/DebugInfo/2010-03-19-DbgDeclare.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/2010-03-19-DbgDeclare.ll?rev=217183&r1=217182&r2=217183&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/2010-03-19-DbgDeclare.ll?rev=217183&r1=217182&r2=217183&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/test/DebugInfo/2010-03-19-DbgDeclare.ll (original)<br>
> +++ llvm/trunk/test/DebugInfo/2010-03-19-DbgDeclare.ll Thu Sep  4 13:55:46 2014<br>
> @@ -1,6 +1,6 @@<br>
>  ; RUN: opt < %s -verify -S | FileCheck %s<br>
><br>
> -; CHECK: [DW_LANG_Mips_Assembler]<br>
> +; CHECK: lang 0x8001<br>
><br>
>  define void @Foo(i32 %a, i32 %b) {<br>
>  entry:<br>
><br>
> Modified: llvm/trunk/test/MC/MachO/gen-dwarf.s<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/MachO/gen-dwarf.s?rev=217183&r1=217182&r2=217183&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/MachO/gen-dwarf.s?rev=217183&r1=217182&r2=217183&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/test/MC/MachO/gen-dwarf.s (original)<br>
> +++ llvm/trunk/test/MC/MachO/gen-dwarf.s Thu Sep  4 13:55:46 2014<br>
> @@ -46,7 +46,7 @@ _x:   .long 1<br>
>  // CHECK:    DW_AT_name [DW_FORM_string]<br>
>  // We don't check the DW_AT_comp_dir which is the current working directory<br>
>  // CHECK:    DW_AT_producer [DW_FORM_string]   ("llvm-mc (based on {{.*}})")<br>
> -// CHECK:    DW_AT_language [DW_FORM_data2]    (DW_LANG_Mips_Assembler)<br>
> +// CHECK:    DW_AT_language [DW_FORM_data2]    (0x8001)<br>
><br>
>  // CHECK:    DW_TAG_label [2] *<br>
>  // CHECK:      DW_AT_name [DW_FORM_string]     ("bar")<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</p>