
<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 03 Sep 2014, at 22:17, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">LGTM</div></div></blockquote><div><br class=""></div><div>This is r217129</div><div><br class=""></div><div>Fred</div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_extra"><div class="gmail_quote">On Wed, Sep 3, 2014 at 12:24 PM, Frédéric Riss <span dir="ltr" class=""><<a href="mailto:friss@apple.com" target="_blank" class="">friss@apple.com</a>></span> wrote:<br class="">

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class="">Here is a new patch with AsFlag removed in favor of accepting TC_Flag in getAsUnsignedConstant() and with getAsBlock implemented as per you suggestion. I can also split that in two pieces if that helps.</div>

<div class=""><br class=""></div><div class=""></div></div><br class=""><div style="word-wrap:break-word" class=""><div class=""></div><br class=""><div class=""><blockquote type="cite" class=""><div class="">On 03 Sep 2014, at 20:56, Frédéric Riss <<a href="mailto:friss@apple.com" target="_blank" class="">friss@apple.com</a>> wrote:</div>

<br class=""><div class=""><div style="word-wrap:break-word" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On 03 Sep 2014, at 20:52, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank" class="">dblaikie@gmail.com</a>> wrote:</div><br class=""><div class="">

<div dir="ltr" class="">What's the need for the getAsFlag function?<br class=""></div></div></blockquote><div class=""><br class=""></div><div class="">FC_Flag is a separate class. I just mimicked the other variants. I can however fold FC_Flag into getAsUnsignedConstant(). This would make the followup patch about symbolic constants a tiny bit simpler.</div>

<div class=""><br class=""></div><blockquote type="cite" class=""><div class=""><div dir="ltr" class="">Perhaps the getAsBlockData/getAsBlockSize could be one function, returning an Optional<ArrayRef<uint8_t*>> ? ("getAsBlock”?)</div></div></blockquote>

<div class=""><br class=""></div><div class="">Great suggestion. I’ll do that and rebase the rest.</div><div class=""><br class=""></div><div class="">Fred</div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Sep 3, 2014 at 11:47 AM, Frédéric Riss <span dir="ltr" class=""><<a href="mailto:friss@apple.com" target="_blank" class="">friss@apple.com</a>></span> wrote:<br class="">

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

These new accessors will be used in subsequent patches.<br class="">

<br class="">

OK to commit?<br class="">

<br class="">

</blockquote></div><br class=""></div>

</div></blockquote></div><br class=""></div>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class=""><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class="">

</div></blockquote></div><br class=""></div><br class=""></blockquote></div><br class=""></div>

</div></blockquote></div><br class=""></body></html>