<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Sep 2, 2014 at 2:02 PM, Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I wonder if we should add a deleted constructor:<br>
<br>
    class StringRef {<br>
    private:<br>
      StringRef(std::string &&) LLVM_DELETED;<br>
    };<br></blockquote><div><br></div><div>unlikely:<br><br>  std::string src();<br>  void sink(StringRef);<br><br>  int main() {<br>    sink(src());<br>  }<br><br>I imagine there's a reasonable amount of that going on in the codebase - though I could be wrong.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
> On 2014 Aug 19, at 14:59, Rafael Espindola <<a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>> wrote:<br>
><br>
> Author: rafael<br>
> Date: Tue Aug 19 13:59:14 2014<br>
> New Revision: 216005<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=216005&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=216005&view=rev</a><br>
> Log:<br>
> Fix a pair of use after free. Should bring the bots back.<br>
><br>
> Modified:<br>
>    llvm/trunk/lib/Object/MachOUniversal.cpp<br>
><br>
> Modified: llvm/trunk/lib/Object/MachOUniversal.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/MachOUniversal.cpp?rev=216005&r1=216004&r2=216005&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/MachOUniversal.cpp?rev=216005&r1=216004&r2=216005&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/lib/Object/MachOUniversal.cpp (original)<br>
> +++ llvm/trunk/lib/Object/MachOUniversal.cpp Tue Aug 19 13:59:14 2014<br>
> @@ -72,7 +72,7 @@ MachOUniversalBinary::ObjectForArch::get<br>
>   if (Parent) {<br>
>     StringRef ParentData = Parent->getData();<br>
>     StringRef ObjectData = ParentData.substr(Header.offset, Header.size);<br>
> -    StringRef ObjectName = Parent->getFileName().str();<br>
> +    StringRef ObjectName = Parent->getFileName();<br>
>     MemoryBufferRef ObjBuffer(ObjectData, ObjectName);<br>
>     return ObjectFile::createMachOObjectFile(ObjBuffer);<br>
>   }<br>
> @@ -84,7 +84,7 @@ std::error_code MachOUniversalBinary::Ob<br>
>   if (Parent) {<br>
>     StringRef ParentData = Parent->getData();<br>
>     StringRef ObjectData = ParentData.substr(Header.offset, Header.size);<br>
> -    std::string ObjectName = Parent->getFileName().str();<br>
> +    StringRef ObjectName = Parent->getFileName();<br>
>     MemoryBufferRef ObjBuffer(ObjectData, ObjectName);<br>
>     ErrorOr<std::unique_ptr<Archive>> Obj = Archive::create(ObjBuffer);<br>
>     if (std::error_code EC = Obj.getError())<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>