<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Robin, </div><div class=""><br class=""></div><div class="">I am sorry for the delay in review. The changes LGTM. </div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Nadav</div><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 2, 2014, at 1:29 PM, Robin Morisset <<a href="mailto:morisset@google.com" class="">morisset@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">ping.</div><div class="gmail_extra"><br class=""><br class=""><div class="gmail_quote">On Wed, Aug 27, 2014 at 2:16 PM, Robin Morisset <span dir="ltr" class=""><<a href="mailto:morisset@google.com" target="_blank" class="">morisset@google.com</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">ping, still waiting on someone with knowledge of the X86 backend.</div><div class="HOEnZb"><div class="h5">
<div class="gmail_extra"><br class=""><br class=""><div class="gmail_quote">On Thu, Aug 7, 2014 at 4:12 PM, Robin Morisset <span dir="ltr" class=""><<a href="mailto:morisset@google.com" target="_blank" class="">morisset@google.com</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Add back the modification to X86CodeEmitter as the Jit resurrected<br class="">
<br class="">
+ an extra comment on the implicitness of the lock prefix before xchg.<br class="">
<div class=""><div class=""><br class="">
<a href="http://reviews.llvm.org/D4796" target="_blank" class="">http://reviews.llvm.org/D4796</a><br class="">
<br class="">
Files:<br class="">
lib/Target/X86/X86CodeEmitter.cpp<br class="">
lib/Target/X86/X86InstrCompiler.td<br class="">
lib/Target/X86/X86MCInstLower.cpp<br class="">
test/CodeGen/X86/atomic_mi.ll<br class="">
</div></div></blockquote></div><br class=""></div>
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>