<div dir="ltr">A more descriptive commit message is helpful here in the future.<div><br></div><div>Thanks!</div><div><br></div><div>-eric</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Aug 25, 2014 at 7:03 PM, Dylan Noblesmith <span dir="ltr"><<a href="mailto:nobled@dreamwidth.org" target="_blank">nobled@dreamwidth.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: nobled<br>
Date: Mon Aug 25 21:03:28 2014<br>
New Revision: 216427<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=216427&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=216427&view=rev</a><br>
Log:<br>
ExecutionEngine: address review comments<br>
<br>
Modified:<br>
    llvm/trunk/lib/ExecutionEngine/ExecutionEngine.cpp<br>
<br>
Modified: llvm/trunk/lib/ExecutionEngine/ExecutionEngine.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/ExecutionEngine.cpp?rev=216427&r1=216426&r2=216427&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/ExecutionEngine.cpp?rev=216427&r1=216426&r2=216427&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/ExecutionEngine/ExecutionEngine.cpp (original)<br>
+++ llvm/trunk/lib/ExecutionEngine/ExecutionEngine.cpp Mon Aug 25 21:03:28 2014<br>
@@ -277,17 +277,16 @@ void *ArgvArray::reset(LLVMContext &C, E<br>
<br>
   for (unsigned i = 0; i != InputArgv.size(); ++i) {<br>
     unsigned Size = InputArgv[i].size()+1;<br>
-    auto DestOwner = make_unique<char[]>(Size);<br>
-    char *Dest = DestOwner.get();<br>
-    Values.push_back(std::move(DestOwner));<br>
-    DEBUG(dbgs() << "JIT: ARGV[" << i << "] = " << (void*)Dest << "\n");<br>
+    auto Dest = make_unique<char[]>(Size);<br>
+    DEBUG(dbgs() << "JIT: ARGV[" << i << "] = " << (void*)Dest.get() << "\n");<br>
<br>
-    std::copy(InputArgv[i].begin(), InputArgv[i].end(), Dest);<br>
+    std::copy(InputArgv[i].begin(), InputArgv[i].end(), Dest.get());<br>
     Dest[Size-1] = 0;<br>
<br>
     // Endian safe: Array[i] = (PointerTy)Dest;<br>
-    EE->StoreValueToMemory(PTOGV(Dest), (GenericValue*)(&Array[i*PtrSize]),<br>
-                           SBytePtr);<br>
+    EE->StoreValueToMemory(PTOGV(Dest.get()),<br>
+                           (GenericValue*)(&Array[i*PtrSize]), SBytePtr);<br>
+    Values.push_back(std::move(Dest));<br>
   }<br>
<br>
   // Null terminate it<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>