<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Aug 30, 2014 at 10:21 AM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">I suspect you'd know better than me. This constructor was my first real experience with type traits.</div>
</blockquote><div><br></div><div>Added a few in r216830 - I think this generally captures the idea. Are there any other conversions, apart from adding cv qualifiers, that we should expect this to allow?<br></div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="gmail_extra"><div><div class="h5">
<br><br><div class="gmail_quote">On Sat, Aug 30, 2014 at 10:13 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">
On Sat, Aug 30, 2014 at 9:48 AM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: ctopper<br>
Date: Sat Aug 30 11:48:19 2014<br>
New Revision: 216821<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=216821&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=216821&view=rev</a><br>
Log:<br>
Add a test for converting ArrayRef<T *> to ArrayRef<const T *>.<br></blockquote><div><br></div><div>Could we use some static_asserts with type traits to check that other things /aren't/ convertible?</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Modified:<br>
llvm/trunk/unittests/ADT/ArrayRefTest.cpp<br>
<br>
Modified: llvm/trunk/unittests/ADT/ArrayRefTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/ArrayRefTest.cpp?rev=216821&r1=216820&r2=216821&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/ArrayRefTest.cpp?rev=216821&r1=216820&r2=216821&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/unittests/ADT/ArrayRefTest.cpp (original)<br>
+++ llvm/trunk/unittests/ADT/ArrayRefTest.cpp Sat Aug 30 11:48:19 2014<br>
@@ -63,4 +63,14 @@ TEST(ArrayRefTest, EmptyEquals) {<br>
EXPECT_TRUE(ArrayRef<unsigned>() == ArrayRef<unsigned>());<br>
}<br>
<br>
+TEST(ArrayRefTest, ConstConvert) {<br>
+ int buf[4];<br>
+ for (int i = 0; i < 4; ++i)<br>
+ buf[i] = i;<br>
+<br>
+ static int *A[] = {&buf[0], &buf[1], &buf[2], &buf[3]};<br>
+ ArrayRef<const int *> a((ArrayRef<int *>(A)));<br>
+ a = ArrayRef<int *>(A);<br>
+}<br>
+<br>
} // end anonymous namespace<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class=""><font color="#888888">-- <br>~Craig
</font></span></div>
</blockquote></div><br></div></div>