<div dir="ltr">I'll try to put together a test case this weekend. As converting the rest of the places that can take advantage of this.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 29, 2014 at 1:58 AM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Any reason not to add a simple unit test so compilation problems are caught earlier rather than later?<div>
<br></div><div>Also, I think LLVM would prefer 'const T *' ... because, you know, its important. ;]</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Aug 28, 2014 at 11:01 PM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Fri Aug 29 01:01:43 2014<br>
New Revision: 216709<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=216709&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=216709&view=rev</a><br>
Log:<br>
Add conversion constructor to convert ArrayRef<T*> to ArrayRef<const T*>. Reviewed with Chandler and David Blaikie.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/ADT/ArrayRef.h<br>
<br>
Modified: llvm/trunk/include/llvm/ADT/ArrayRef.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/ArrayRef.h?rev=216709&r1=216708&r2=216709&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/ArrayRef.h?rev=216709&r1=216708&r2=216709&view=diff</a><br>


==============================================================================<br>
--- llvm/trunk/include/llvm/ADT/ArrayRef.h (original)<br>
+++ llvm/trunk/include/llvm/ADT/ArrayRef.h Fri Aug 29 01:01:43 2014<br>
@@ -104,6 +104,14 @@ namespace llvm {<br>
       Length(Vec.size()) {}<br>
 #endif<br>
<br>
+    /// Construct an ArrayRef<const T*> from ArrayRef<T*>. This uses SFINAE to<br>
+    /// ensure that only ArrayRefs of pointers can be converted.<br>
+    template <typename U><br>
+    ArrayRef(const ArrayRef<U *> &A,<br>
+             typename std::enable_if<<br>
+                 std::is_convertible<U *const *, T const *>::value>::type* = 0)<br>
+      : Data(A.data()), Length(A.size()) {}<br>
+<br>
     /// @}<br>
     /// @name Simple Operations<br>
     /// @{<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>~Craig
</div>