<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif;">
<div>Hi All,</div>
<div><br>
</div>
<div>Thanks, committed as r21614[01].</div>
<div><br>
</div>
<div>Gerolf, I didn’t do specific checking of compile time for this change because it is just adding a bailout condition – I can’t see how that could significantly alter compile time.</div>
<div><br>
</div>
<div>Cheers, and sorry for the high latency on this one,</div>
<div><br>
</div>
<div>James</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>Gerolf Hoflehner <<a href="mailto:ghoflehner@apple.com">ghoflehner@apple.com</a>><br>
<span style="font-weight:bold">Date: </span>Wednesday, 13 August 2014 21:25<br>
<span style="font-weight:bold">To: </span>Arnold Schwaighofer <<a href="mailto:aschwaighofer@apple.com">aschwaighofer@apple.com</a>>, Admin <<a href="mailto:james.molloy@arm.com">james.molloy@arm.com</a>><br>
<span style="font-weight:bold">Cc: </span>James Molloy <<a href="mailto:james@jamesmolloy.co.uk">james@jamesmolloy.co.uk</a>>, Hal Finkel <<a href="mailto:hfinkel@anl.gov">hfinkel@anl.gov</a>>, Admin <<a href="mailto:james.molloy@arm.com">james.molloy@arm.com</a>>,
"<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>" <<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>><br>
<span style="font-weight:bold">Subject: </span>Re: [PATCH][LoopVectorizer] Restrict the unroll factor of reductions in loops<br>
</div>
<div><br>
</div>
<div>
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
There are a number of regression (lowercase -40%, link pack ~-5%) and gains (puzzle? >30%, sgefa > 13%). I’ll do some analysis in the next couple of days and follow up with bug filings as necessary. So go for the gains for now and trust that we’ll recover the
losses.
<div><br>
</div>
<div>I haven’t done any compile-time measurements for the patch. Did you cover it with high confidence?<br>
<div><br>
</div>
<div>Thanks</div>
<div>Gerolf</div>
<div><br>
<div>
<div><br>
</div>
<div><br>
<div>
<div>On Aug 12, 2014, at 10:19 AM, Arnold Schwaighofer <<a href="mailto:aschwaighofer@apple.com">aschwaighofer@apple.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
LGTM.
<div class=""><br class="">
</div>
<div class="">I did see some regressions running the whole test-suite on the two patches (+ "ST->isCyclone()") we (on our end) might want to look into - I’ll send my results to Gerolf.</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Arnold</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Aug 11, 2014, at 9:17 AM, James Molloy <<a href="mailto:james@jamesmolloy.co.uk" class="">james@jamesmolloy.co.uk</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" class="">Hi Arnold, Gerolf, Hal,
<div class=""><br class="">
</div>
<div class="">Good idea about a tuning option. Attached is a patch that implements that tuning option. Is it OK to commit?</div>
<div class=""><br class="">
</div>
<div class="">Gerolf, did you want me to add "|| isCyclone()" to AArch64TargetTransformInfo?</div>
<div class=""><br class="">
</div>
<div class="">Cheers,</div>
<div class=""><br class="">
</div>
<div class="">James</div>
</div>
<div class="gmail_extra"><br class="">
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</div>
</div>
</span><br>
<font face="Arial" color="Black" size="2">-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents
to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.<br>
<br>
ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590<br>
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782<br>
</font>
</body>
</html>