<p dir="ltr"><br>
On Aug 21, 2014 6:25 PM, "Hans Wennborg" <<a href="mailto:hans@hanshq.net">hans@hanshq.net</a>> wrote:<br>
><br>
> Author: hans<br>
> Date: Thu Aug 21 20:13:29 2014<br>
> New Revision: 216252<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=216252&view=rev">http://llvm.org/viewvc/llvm-project?rev=216252&view=rev</a><br>
> Log:<br>
> Fix build after r216223: Explicitly pass ownership of the MemoryBuffer to AddNewSourceBuffer using std::unique_ptr</p>
<p dir="ltr">Sorry about the fallout - thanks for fixing it up!</p>
<p dir="ltr">><br>
> Modified:<br>
>     lld/trunk/include/lld/Driver/WinLinkModuleDef.h<br>
>     lld/trunk/include/lld/ReaderWriter/LinkerScript.h<br>
><br>
> Modified: lld/trunk/include/lld/Driver/WinLinkModuleDef.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Driver/WinLinkModuleDef.h?rev=216252&r1=216251&r2=216252&view=diff">http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Driver/WinLinkModuleDef.h?rev=216252&r1=216251&r2=216252&view=diff</a><br>

> ==============================================================================<br>
> --- lld/trunk/include/lld/Driver/WinLinkModuleDef.h (original)<br>
> +++ lld/trunk/include/lld/Driver/WinLinkModuleDef.h Thu Aug 21 20:13:29 2014<br>
> @@ -54,7 +54,7 @@ public:<br>
>  class Lexer {<br>
>  public:<br>
>    explicit Lexer(std::unique_ptr<MemoryBuffer> mb) : _buffer(mb->getBuffer()) {<br>
> -    _sourceManager.AddNewSourceBuffer(mb.release(), llvm::SMLoc());<br>
> +    _sourceManager.AddNewSourceBuffer(std::move(mb), llvm::SMLoc());<br>
>    }<br>
><br>
>    Token lex();<br>
><br>
> Modified: lld/trunk/include/lld/ReaderWriter/LinkerScript.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/ReaderWriter/LinkerScript.h?rev=216252&r1=216251&r2=216252&view=diff">http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/ReaderWriter/LinkerScript.h?rev=216252&r1=216251&r2=216252&view=diff</a><br>

> ==============================================================================<br>
> --- lld/trunk/include/lld/ReaderWriter/LinkerScript.h (original)<br>
> +++ lld/trunk/include/lld/ReaderWriter/LinkerScript.h Thu Aug 21 20:13:29 2014<br>
> @@ -58,7 +58,7 @@ class Lexer {<br>
>  public:<br>
>    explicit Lexer(std::unique_ptr<MemoryBuffer> mb)<br>
>        : _buffer(mb->getBuffer()) {<br>
> -    _sourceManager.AddNewSourceBuffer(mb.release(), llvm::SMLoc());<br>
> +    _sourceManager.AddNewSourceBuffer(std::move(mb), llvm::SMLoc());<br>
>    }<br>
><br>
>    void lex(Token &tok);<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</p>