<html><body><div style="color:#000; background-color:#fff; font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:12pt"><div class="" style=""><span class="" style="">Hi Tim,</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-style: normal; background-color: transparent;" class=""><span class="" style=""><br class="" style=""></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-style: normal; background-color: transparent;" class=""><span class="" style="">OK. Changed that format and committed as r216066.</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-style: normal; background-color:
transparent;" class=""><span class="" style=""><br></span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-style: normal; background-color: transparent;" class=""><span class="" style="">Thanks,</span></div><div style="color: rgb(0, 0, 0); font-size: 16px; font-family: HelveticaNeue, 'Helvetica Neue', Helvetica, Arial, 'Lucida Grande', sans-serif; font-style: normal; background-color: transparent;" class=""><span class="" style="">-Jiangning</span></div> <div class="qtdSeparateBR"><br><br></div><div class="yahoo_quoted" style="display: block;"> <div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 12pt;" class=""> <div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 12pt;" class=""> <div dir="ltr" class="" style=""> <font size="2"
face="Arial" class="" style=""> On Wednesday, August 20, 2014 6:03 PM, Tim Northover <t.p.northover@gmail.com> wrote:<br class="" style=""> </font> </div> <br class="" style=""><br class="" style=""> <div class="" style="">Hi Jiangning,<br clear="none" class="" style=""><br clear="none" class="" style="">Thanks for updating again. I think this looks fine apart from one tiny formatting thing I spotted (sorry). Feel free to commit it with that change.<br clear="none" class="" style=""><br clear="none" class="" style="">Tim.<br clear="none" class="" style=""><br clear="none" class="" style="">================<br clear="none" class="" style="">Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:760-761<br clear="none" class="" style="">@@ -759,1 +759,4 @@<br clear="none" class="" style=""> <br clear="none" class="" style="">+static ISD::NodeType getPreferredExtendForValue(const Value *V)<br clear="none" class="" style="">+{<br clear="none"
class="" style="">+ // For the users of the source value being used for compare instruction, if<br clear="none" class="" style="">----------------<br clear="none" class="" style="">Formatting.<div class="" id="yqtfd10287" style=""><br clear="none" class="" style=""><br clear="none" class="" style=""><a shape="rect" href="http://reviews.llvm.org/D4967" target="_blank" class="" style="">http://reviews.llvm.org/D4967</a><br clear="none" class="" style=""><br clear="none" class="" style=""><br clear="none" class="" style=""><br clear="none" class="" style="">_______________________________________________<br clear="none" class="" style="">llvm-commits mailing list<br clear="none" class="" style=""><a shape="rect" ymailto="mailto:llvm-commits@cs.uiuc.edu" href="mailto:llvm-commits@cs.uiuc.edu" class="" style="">llvm-commits@cs.uiuc.edu</a><br clear="none" class="" style=""><a shape="rect" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"
target="_blank" class="" style="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br clear="none" class="" style=""></div><br class="" style=""><br class="" style=""></div> </div> </div> </div> </div></body></html>