<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div style=""><div>On Aug 15, 2014, at 9:13 AM, Tom Stellard <<a href="mailto:tom@stellard.net">tom@stellard.net</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Wed, Aug 06, 2014 at 06:56:37PM -0700, Matt Arsenault wrote:<br><br>LGTM.<br><br><blockquote type="cite"><br>On Aug 6, 2014, at 10:34 AM, Matt Arsenault <<a href="mailto:arsenm2@gmail.com">arsenm2@gmail.com</a>> wrote:<br><br><blockquote type="cite"><br>On Aug 6, 2014, at 12:25 AM, Michel Dänzer <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>> wrote:<br><br><blockquote type="cite"><br><blockquote type="cite">Here is an updated set that implements that for f64. These also<br>switch to preferring using the literal constant as the first operand,<br>rather than loading the immediate into a register.<br></blockquote><br>Sounds good, but I have to defer to Tom or others for review.<br><br></blockquote><br>I think I’m going to go back on this. It’s mostly a cosmetic change in the scalar case, trading a move of an immediate for one from an SGPR to VGPR. In the vector case, this would require N SGPR copies, but the other way the SGPRs could stay and only 1 copy of the immediate would need to be loaded.<br></blockquote><br><br><br>These switch back to preferring the old order of literal loaded into a VGPR, and remove the FABS_SI / FNEG_SI pseudoinstructions. I don’t see any need for them anymore, and the pattern can directly match the instructions<br><br><br></blockquote><br><blockquote type="cite">_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></blockquote></div></blockquote></div><br><div>r215746 - r215749</div></body></html>