<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Aug 13, 2014, at 2:34 AM, Demikhovsky, Elena <<a href="mailto:elena.demikhovsky@intel.com">elena.demikhovsky@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 14px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">About patch 0004.<br><br>I built a map for LowerINTRINSIC_W_CHAIN to reduce amount of code. May be you want to build one more map for LowerINTRINSIC_WO_CHAIN ?<br></div></blockquote><div><br></div><div>Yeah, I think that’s a good idea but we should probably do that in a follow-on patch.</div><div><br></div><div>Adam</div><br><blockquote type="cite"><div style="font-size: 14px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br><br>- Elena<br><br><br>-----Original Message-----<br>From: Adam Nemet [<a href="mailto:anemet@apple.com">mailto:anemet@apple.com</a>]<span class="Apple-converted-space"> </span><br>Sent: Tuesday, August 12, 2014 23:36<br>To: Demikhovsky, Elena; Robert Khasanov<br>Cc: llvm-commits<br>Subject: [PATCH][AVX512] FMA masking instruction variants and intrinsics<br><br>Hi,<br><br>Elena made the comment regarding the FMA intrinsics earlier to try to only expose the masking versions as intrinsics rather than having two sets of the intrinsics (masking, unconditional: with an all-one mask). These changes implement that.<br><br>The flow of the patchset is to first adjust the masking base class to accommodate the FMA instruction and then add the variants. We also need to rename the existing intrinsics to masking and provide the lowering.<br><br>Along the way there are some cleanup and refactoring patches as well. Hopefully this should be clear from the log in the individual patch files.<br><br>As the last patch, I've included the intrinsic header diff I am planning to commit in CFE. I followed the existing precedence set by AVX to use the LLVM intrinsic for nmadd rather than negate the first operand and fall back on the madd intrinsic. We can also change that later if that seems more appropriate assuming of course that codegen will recover the nmadd.<br><br>Thanks and please let me know if it looks good.<br><br>Adam<br>---------------------------------------------------------------------<br>Intel Israel (74) Limited<br><br>This e-mail and any attachments may contain confidential material for<br>the sole use of the intended recipient(s). Any review or distribution<br>by others is strictly prohibited. If you are not the intended<br>recipient, please contact the sender and delete all copies.</div></blockquote></div><br></body></html>