<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Thanks, Robert, it’s r215473.<div><br></div><div>Adam</div><div><br><div><div>On Aug 12, 2014, at 6:19 AM, Robert Khasanov <<a href="mailto:rob.khasanov@gmail.com">rob.khasanov@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">LGTM</div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-08-08 10:32 GMT+04:00 Adam Nemet <span dir="ltr"><<a href="mailto:anemet@apple.com" target="_blank">anemet@apple.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
I think that this will scale better in most cases than adding a Pat<> for each<br>
mapping from the intrinsic DAG to the intruction (i.e. rri, rrik, rrikz). We<br>
can just lower to the SDNode and have the resulting DAG be matches by the DAG<br>
patterns.<br>
<br>
Alternatively (long term), we could keep the Pat<>s but generate them via the<br>
new AVX512_masking multiclass. The difficulty is that in order to formulate<br>
that we would have to concatenate DAGs in tablegen. Currently this is only<br>
supported if the operators of the input DAGs are identical.<br>
<br>
Please let me know if it looks good.<br>
<span class="HOEnZb"><font color="#888888"><br>
Adam<br>
<br>
</font></span></blockquote></div><br></div>
</blockquote></div><br></div></body></html>