<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div style=""><div>On Aug 6, 2014, at 6:56 PM, Matt Arsenault <<a href="mailto:arsenm2@gmail.com">arsenm2@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Aug 6, 2014, at 10:34 AM, Matt Arsenault <<a href="mailto:arsenm2@gmail.com">arsenm2@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Aug 6, 2014, at 12:25 AM, Michel Dänzer <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br><blockquote type="cite">Here is an updated set that implements that for f64. These also<br>switch to preferring using the literal constant as the first operand,<br>rather than loading the immediate into a register.<br></blockquote><br>Sounds good, but I have to defer to Tom or others for review.<br><br></div></blockquote></div><br><div>I think I’m going to go back on this. It’s mostly a cosmetic change in the scalar case, trading a move of an immediate for one from an SGPR to VGPR. In the vector case, this would require N SGPR copies, but the other way the SGPRs could stay and only 1 copy of the immediate would need to be loaded.</div></div></blockquote></div><br><div><br></div><div><br></div><div>These switch back to preferring the old order of literal loaded into a VGPR, and remove the FABS_SI / FNEG_SI pseudoinstructions. I don’t see any need for them anymore, and the pattern can directly match the instructions</div><div><br></div><div><br></div><div></div></div><span><0001-R600-SI-Refactor-fneg-fabs-patterns.patch></span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div></div></div><span><0002-R600-SI-Use-source-modifier-for-f64-fabs.patch></span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div></div></div><span><0003-R600-SI-Use-source-modifiers-for-f64-fneg.patch></span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div></div></div><span><0004-R600-SI-Move-all-fabs-fneg-handling-to-patterns.patch></span><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div></div></div></blockquote></div><br><div><br></div><div>Ping</div></body></html>