On Monday, August 11, 2014, Alex Lorenz <<a href="mailto:arphaman@gmail.com">arphaman@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The updated patch removes the test for class.cpp and derivedclass.cpp which will go into a separate patch because they require another patch in order to pass on windows.<br>

The other tests were modified according to Justin's suggestions.</blockquote><div><br></div><div>Where you use multiple check prefixes please give them more specific names than CHECK1 and CHECK2. Names like CHECK-FUNC AND CHECK-STATIC-FUNC would be good choices.</div>
<div><br></div><div>With those changes, please go ahead and commit. I don't need to see the updated version first.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<a href="http://reviews.llvm.org/D4847" target="_blank">http://reviews.llvm.org/D4847</a><br>
<br>
Files:<br>
  test/CoverageMapping/Inputs/code.h<br>
  test/CoverageMapping/Inputs/header1.h<br>
  test/CoverageMapping/break.c<br>
  test/CoverageMapping/builtinmacro.c<br>
  test/CoverageMapping/casts.c<br>
  test/CoverageMapping/classtemplate.cpp<br>
  test/CoverageMapping/continue.c<br>
  test/CoverageMapping/header.cpp<br>
  test/CoverageMapping/if.c<br>
  test/CoverageMapping/includehell.cpp<br>
  test/CoverageMapping/ir.c<br>
  test/CoverageMapping/label.cpp<br>
  test/CoverageMapping/logical.cpp<br>
  test/CoverageMapping/loopmacro.c<br>
  test/CoverageMapping/loops.cpp<br>
  test/CoverageMapping/macroception.c<br>
  test/CoverageMapping/macroparams.c<br>
  test/CoverageMapping/macroparams2.c<br>
  test/CoverageMapping/macros.c<br>
  test/CoverageMapping/nestedclass.cpp<br>
  test/CoverageMapping/preprocessor.c<br>
  test/CoverageMapping/return.c<br>
  test/CoverageMapping/switch.c<br>
  test/CoverageMapping/templates.cpp<br>
  test/CoverageMapping/test.c<br>
  test/CoverageMapping/trycatch.cpp<br>
</blockquote>