<div dir="ltr">Thanks Tim,<div><br></div><div>Using unique_ptr ended up making the code harder to read, so I simply added a deletion loop which I think is cleaner.</div><div><br></div><div>Committed in r215199, thankyou to all reviewers!</div>
<div><br></div><div>Cheers,</div><div><br></div><div>James</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 8 August 2014 10:42, Tim Northover <span dir="ltr"><<a href="mailto:t.p.northover@gmail.com" target="_blank">t.p.northover@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Just added llvm-commits.<br>
<br>
================<br>
Comment at: lib/Target/AArch64/AArch64A57FPLoadBalancing.cpp:318<br>
@@ +317,3 @@<br>
+  // "link" register between each inst in the chain.<br>
+  std::map<unsigned, Chain*> ActiveChains;<br>
+  std::set<Chain*> AllChains;<br>
----------------<br>
Tim Northover wrote:<br>
> Aren't these chains leaked? It *looks* like you could make this (or the set) a unique_ptr<Chain>.<br>
Also, this should definitely be the set. I hadn't noticed things get removed from ActiveChains when I wrote this. Should have been obvious, in retrospect.<br>
<br>
<a href="http://reviews.llvm.org/D4791" target="_blank">http://reviews.llvm.org/D4791</a><br>
<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>