<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Sounds good.<div><br></div><div>Committed in r<span style="font-family: Menlo; font-size: 11px;">214599</span></div><div><br></div><div>Tyler</div><div><br><div><div>On Aug 1, 2014, at 5:00 PM, Arnold Schwaighofer <<a href="mailto:aschwaighofer@apple.com">aschwaighofer@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"> if (!EnableCondStoresVectorization && Legal->NumPredStores) {<br>+ emitAnalysis(Report() << "loop control flow is not understood by vectorizer");<br> DEBUG(dbgs() << "LV: No vectorization. There are conditional stores.\n");<br> return Factor;<br> }<br><br>Should we maybe say “store that is conditionally executed prevents vectorization”?<br><br>Otherwise LGTM.<br><br>Thanks!<br><br><blockquote type="cite">On Aug 1, 2014, at 4:52 PM, Tyler Nowicki <<a href="mailto:tnowicki@apple.com">tnowicki@apple.com</a>> wrote:<br><br>Hi,<br><br>Here is a patch that adds diagnostics to the vectorizer cost model. When the cost model determines vectorization is not possible/profitable these remarks print an analysis of that decision. I include one test. It is difficult to find tests that fail at this point. If you know of any please let me know and I will include them.<br><br>Note that in selectVectorizationFactor() we can assume that OptForSize and ForceVectorization are mutually exclusive.<br><br>Tyler<br><br><diagnostics_in_cost_model-svn.patch><br></blockquote><br></blockquote></div><br></div></body></html>