<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Thanks!</div><div><br></div><div>Committed in r<span style="font-family: Menlo; font-size: 11px;">214445 and r</span><span style="font-family: Menlo; font-size: 11px;">214440.</span></div><br><div><div>On Jul 30, 2014, at 8:22 AM, Arnold Schwaighofer <<a href="mailto:aschwaighofer@apple.com">aschwaighofer@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Index: lib/Transforms/Vectorize/LoopVectorize.cpp<br>===================================================================<br>--- lib/Transforms/Vectorize/LoopVectorize.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>(revision 214114)<br>+++ lib/Transforms/Vectorize/LoopVectorize.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>(working copy)<br>@@ -3676,7 +3676,8 @@<br> continue;<br> }<br><br>- emitAnalysis(Report(it) << "unvectorizable operation");<br>+ emitAnalysis(Report(it) << "value that could not be identified as "<br>+ "reduction is used outside the loop");<br> DEBUG(dbgs() << "LV: Found an unidentified PHI."<< *Phi <<"\n");<br> return false;<br> }// end of PHI handling<br><br>The loop vectorizer classifies phi cycles as either induction or reduction variables. If it ends up here it could identify them as neither. <br><br>“value could not be identified as induction or reduction variable”<br><br>With the change LGTM.<br><br><blockquote type="cite">On Jul 28, 2014, at 12:42 PM, Tyler Nowicki <<a href="mailto:tnowicki@apple.com">tnowicki@apple.com</a>> wrote:<br><br>Hi,<br><br>Here is two patches to improve the vectorization diagnostic remarks so the output is more intelligible. The first patch improves the remark generated when a variable is used outside the loop but it is not a reduction. The second patch improves the remark generated for -Rpass-missed.<br><br>Tyler<br><br><improve_no_outside_user_remarks-svn.patch><br><br><improve_pass-missed-remarks-svn.patch><br></blockquote><br></blockquote></div><br></body></html>