<div dir="ltr">Thanks. There may be a few more.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 29, 2014 at 11:30 PM, Bill Wendling <span dir="ltr"><<a href="mailto:isanbard@gmail.com" target="_blank">isanbard@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Okay. done.<span class="HOEnZb"><font color="#888888"><div><br></div><div>-bw</div></font></span><div>
<div class="h5"><div><br><div><div>On Jul 29, 2014, at 11:28 PM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com" target="_blank">chandlerc@gmail.com</a>> wrote:</div><br><blockquote type="cite"><div dir="ltr">
Bill, please merge this into the 3.5 release.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 29, 2014 at 10:44 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@gmail.com" target="_blank">chandlerc@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chandlerc<br>
Date: Wed Jul 30 00:44:04 2014<br>
New Revision: 214287<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=214287&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=214287&view=rev</a><br>
Log:<br>
Don't manually (and forcibly) run the verifier on the entire module from<br>
the jump instruction table pass. First, the verifier is already built<br>
into all the tools. The test case is adapted to just run llvm-as<br>
demonstrating that we still catch the broken module. Second, the<br>
verifier is *extremely* slow. This was responsible for very significant<br>
compile time regressions.<br>
<br>
If you have deployed a Clang binary anywhere from r210280 to this<br>
commit, you really want to re-deploy.<br>
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/JumpInstrTables.cpp<br>
    llvm/trunk/test/Verifier/jumptable.ll<br>
<br>
Modified: llvm/trunk/lib/CodeGen/JumpInstrTables.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/JumpInstrTables.cpp?rev=214287&r1=214286&r2=214287&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/JumpInstrTables.cpp?rev=214287&r1=214286&r2=214287&view=diff</a><br>


==============================================================================<br>
--- llvm/trunk/lib/CodeGen/JumpInstrTables.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/JumpInstrTables.cpp Wed Jul 30 00:44:04 2014<br>
@@ -251,10 +251,6 @@ FunctionType *JumpInstrTables::transform<br>
 }<br>
<br>
 bool JumpInstrTables::runOnModule(Module &M) {<br>
-  // Make sure the module is well-formed, especially with respect to jumptable.<br>
-  if (verifyModule(M))<br>
-    return false;<br>
-<br>
   JITI = &getAnalysis<JumpInstrTableInfo>();<br>
<br>
   // Get the set of jumptable-annotated functions.<br>
<br>
Modified: llvm/trunk/test/Verifier/jumptable.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/jumptable.ll?rev=214287&r1=214286&r2=214287&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Verifier/jumptable.ll?rev=214287&r1=214286&r2=214287&view=diff</a><br>


==============================================================================<br>
--- llvm/trunk/test/Verifier/jumptable.ll (original)<br>
+++ llvm/trunk/test/Verifier/jumptable.ll Wed Jul 30 00:44:04 2014<br>
@@ -1,4 +1,4 @@<br>
-; RUN: not llc <%s 2>&1 | FileCheck %s<br>
+; RUN: not llvm-as -disable-output %s 2>&1 | FileCheck %s<br>
<br>
 define i32 @f() jumptable {<br>
   ret i32 0<br>
@@ -6,4 +6,3 @@ define i32 @f() jumptable {<br>
<br>
 ; CHECK: Attribute 'jumptable' requires 'unnamed_addr'<br>
 ; CHECK: i32 ()* @f<br>
-; CHECK: LLVM ERROR: Broken function found, compilation aborted!<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</blockquote></div><br></div></div></div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>