<div dir="ltr">Hi,<div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, May 21, 2014 at 11:21 AM, Evgeniy Stepanov <span dir="ltr"><<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: eugenis<br>
Date: Wed May 21 03:21:14 2014<br>
New Revision: 209282<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=209282&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=209282&view=rev</a><br>
Log:<br>
[asan] Fix x86 asm instrumentation to preserve flags.<br>
<br>
This change also enables asm instrumentation in asan tests that was<br>
accidentally disabled yearlier, and adds a sanity test for that.<br>
<br>
Patch by Yuri Gorshenin.<br>
<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/asan/asan_asm_instrumentation.S<br>
    compiler-rt/trunk/lib/asan/scripts/gen_asm_instrumentation.sh<br>
    compiler-rt/trunk/lib/asan/tests/CMakeLists.txt<br>
    compiler-rt/trunk/lib/asan/tests/asan_asm_test.cc<br>
<br></blockquote><div><br></div><div>This doesn't seem to work on ARM/Linux, -asan-instrument-assembly option unknown:</div><div><br></div><div><div>[/havana/sources/llvm/build]> ninja -j1 check-all</div><div>[2/32] Generating ASAN_INST_TEST_OBJECTS.asan_globals_test.cc.arm-inline.o</div>

<div>FAILED: cd /havana/sources/llvm/build/projects/compiler-rt/lib/asan/tests && /havana/sources/llvm/build/./bin/clang -mfloat-abi=hard -mtune=cortex-a8 -mfpu=neon -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings -Wmissing-field-initializers -pedantic -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor -std=c++11 -fcolor-diagnostics -ffunction-sections -fdata-sections -Wall -std=c++11 -Wno-unknown-warning-option -DGTEST_NO_LLVM_RAW_OSTREAM=1 -DGTEST_HAS_RTTI=0 -I/havana/sources/llvm/utils/unittest/googletest/include -I/havana/sources/llvm/utils/unittest/googletest -I/havana/sources/llvm/projects/compiler-rt/include -I/havana/sources/llvm/projects/compiler-rt/lib -I/havana/sources/llvm/projects/compiler-rt/lib/asan -I/havana/sources/llvm/projects/compiler-rt/lib/sanitizer_common/tests -fno-rtti -O2 -Wno-format -Werror=sign-compare -Wno-variadic-macros -gline-tables-only -DASAN_HAS_BLACKLIST=1 -DASAN_HAS_EXCEPTIONS=1 -DASAN_UAR=0 -fsanitize=address -fsanitize-blacklist=/havana/sources/llvm/projects/compiler-rt/lib/asan/tests/asan_test.ignore -mllvm -asan-instrument-assembly -march=armv7-a -c -o ASAN_INST_TEST_OBJECTS.asan_globals_test.cc.arm-inline.o /havana/sources/llvm/projects/compiler-rt/lib/asan/tests/asan_globals_test.cc</div>

<div>clang (LLVM option parsing): Unknown command line argument '-asan-instrument-assembly'.  Try: 'clang (LLVM option parsing) -help'</div><div>clang (LLVM option parsing): Did you mean '-asan-instrument-atomics'?</div>

<div>ninja: build stopped: subcommand failed.</div></div><div><br></div><div><br></div></div></div></div>