<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 07/26/2014 09:41 AM, Sean Silva
wrote:<br>
</div>
<blockquote
cite="mid:CAHnXoanYKFTzZrbMWXhLaeXWq=UjAC1DJ23r7yCKCsRqo2Nk8w@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Thu, Jul 24, 2014 at 6:30 PM,
Philip Reames <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:listmail@philipreames.com" target="_blank">listmail@philipreames.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> I fully accept your
internal tool argument, but given the documentation is
more or less "see what google says", making flag
migrations obvious seems like a helpful thing. :)<span
class=""><font color="#888888"><br>
<br>
</font></span></div>
</blockquote>
<div><br>
</div>
<div>Actually LLI supposedly has its own man page: <a
moz-do-not-send="true"
href="http://llvm.org/docs/CommandGuide/lli.html">http://llvm.org/docs/CommandGuide/lli.html</a></div>
<div>
<div>
I have no idea how up-to-date it is though.</div>
</div>
</div>
</div>
</div>
</blockquote>
Given this page doesn't even *mention* mcjit, not very.<br>
<br>
We should fix that. <br>
<blockquote
cite="mid:CAHnXoanYKFTzZrbMWXhLaeXWq=UjAC1DJ23r7yCKCsRqo2Nk8w@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div>(so do many other of our tools: <a
moz-do-not-send="true"
href="http://llvm.org/docs/CommandGuide/">http://llvm.org/docs/CommandGuide/</a>
)</div>
<div><br>
</div>
<div>-- Sean Silva</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span class=""><font
color="#888888"> Philip</font></span>
<div>
<div class="h5"><br>
<br>
<div>On 07/24/2014 03:19 PM, Lang Hames wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>Hi Philip,</div>
<div><br>
</div>
<div>I think adding a short-term warning is a
good idea. When the old JIT is removed
however, the plan is for this option to be
removed too. LLI is an internal tool, and
doesn't guarantee backwards compatibility with
flags.</div>
<div><br>
</div>
<div>
<div>- Lang.</div>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Thu, Jul 24, 2014 at
2:33 PM, Philip Reames <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:listmail@philipreames.com"
target="_blank">listmail@philipreames.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
On 07/23/2014 09:26 PM, Rafael Espíndola
wrote:<br>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
- cl::opt<bool> UseMCJIT(<br>
- "use-mcjit", cl::desc("Enable use of
the MC-based JIT (if available)"),<br>
- cl::init(false));<br>
-<br>
</blockquote>
I would suggest that we leave this option in
and switch the default. This keeps command
line compatibility for all users.<br>
<br>
We should add an explicit warning/error for
!UseMCJIT though. If someone is explicitly
opting out of MCJIT, we should probably let
them know that's not an option any more.<br>
<br>
This would even make sense as a separate
change a few days before anything else. It
would help flush out things which
unknowingly or implicitly depend on using
the old JIT.<br>
<br>
<br>
Also, where is the documentation change?
That should be part of the very first
patch. :)<span><font color="#888888"><br>
<br>
Philip</font></span>
<div>
<div><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:llvm-commits@cs.uiuc.edu"
target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<br>
</body>
</html>