<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jul 24, 2014, at 6:46 AM, Tom Stellard <<a href="mailto:tom@stellard.net">tom@stellard.net</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Thu, Jul 24, 2014 at 02:10:17AM -0000, Matt Arsenault wrote:<br><blockquote type="cite">Author: arsenm<br>Date: Wed Jul 23 21:10:17 2014<br>New Revision: 213831<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=213831&view=rev">http://llvm.org/viewvc/llvm-project?rev=213831&view=rev</a><br>Log:<br>R600: Implement enableClusterLoads()<br><br>Modified:<br> llvm/trunk/lib/Target/R600/AMDGPUInstrInfo.cpp<br> llvm/trunk/lib/Target/R600/AMDGPUInstrInfo.h<br><br>Modified: llvm/trunk/lib/Target/R600/AMDGPUInstrInfo.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/AMDGPUInstrInfo.cpp?rev=213831&r1=213830&r2=213831&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/AMDGPUInstrInfo.cpp?rev=213831&r1=213830&r2=213831&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/Target/R600/AMDGPUInstrInfo.cpp (original)<br>+++ llvm/trunk/lib/Target/R600/AMDGPUInstrInfo.cpp Wed Jul 23 21:10:17 2014<br>@@ -215,6 +215,10 @@ AMDGPUInstrInfo::getOpcodeAfterMemoryUnf<br> return 0;<br>}<br><br>+bool AMDGPUInstrInfo::enableClusterLoads() const {<br>+ return true;<br>+}<br>+<br></blockquote><br>What is this callback used for?<br><br>-Tom<br></div></blockquote><div><br></div><div><br></div><div>It’s the missing enabler to make the already implemented shouldScheduleLoadsNear, which should enable some load clustering in the DAG scheduler</div><div><br></div><br><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br><blockquote type="cite">bool AMDGPUInstrInfo::shouldScheduleLoadsNear(SDNode *Load1, SDNode *Load2,<br> int64_t Offset1, int64_t Offset2,<br> unsigned NumLoads) const {<br><br>Modified: llvm/trunk/lib/Target/R600/AMDGPUInstrInfo.h<br>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/AMDGPUInstrInfo.h?rev=213831&r1=213830&r2=213831&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/AMDGPUInstrInfo.h?rev=213831&r1=213830&r2=213831&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/Target/R600/AMDGPUInstrInfo.h (original)<br>+++ llvm/trunk/lib/Target/R600/AMDGPUInstrInfo.h Wed Jul 23 21:10:17 2014<br>@@ -120,6 +120,9 @@ public:<br> unsigned getOpcodeAfterMemoryUnfold(unsigned Opc,<br> bool UnfoldLoad, bool UnfoldStore,<br> unsigned *LoadRegIndex = nullptr) const override;<br>+<br>+ bool enableClusterLoads() const override;<br>+<br> bool shouldScheduleLoadsNear(SDNode *Load1, SDNode *Load2,<br> int64_t Offset1, int64_t Offset2,<br> unsigned NumLoads) const override;<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></body></html>