<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I fully accept your internal tool argument, but given the
documentation is more or less "see what google says", making flag
migrations obvious seems like a helpful thing. :)<br>
<br>
Philip<br>
<br>
<div class="moz-cite-prefix">On 07/24/2014 03:19 PM, Lang Hames
wrote:<br>
</div>
<blockquote
cite="mid:CALLttgo2Z9PNR_hs5BTSGM+aKPwp1+NDWEOFehb7QLmoopM+CQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>Hi Philip,</div>
<div><br>
</div>
<div>I think adding a short-term warning is a good idea. When
the old JIT is removed however, the plan is for this option to
be removed too. LLI is an internal tool, and doesn't guarantee
backwards compatibility with flags.</div>
<div><br>
</div>
<div>
<div>- Lang.</div>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Thu, Jul 24, 2014 at 2:33 PM, Philip
Reames <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:listmail@philipreames.com" target="_blank">listmail@philipreames.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
On 07/23/2014 09:26 PM, Rafael Espíndola wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
- cl::opt<bool> UseMCJIT(<br>
- "use-mcjit", cl::desc("Enable use of the MC-based JIT
(if available)"),<br>
- cl::init(false));<br>
-<br>
</blockquote>
I would suggest that we leave this option in and switch the
default. This keeps command line compatibility for all
users.<br>
<br>
We should add an explicit warning/error for !UseMCJIT
though. If someone is explicitly opting out of MCJIT, we
should probably let them know that's not an option any more.<br>
<br>
This would even make sense as a separate change a few days
before anything else. It would help flush out things which
unknowingly or implicitly depend on using the old JIT.<br>
<br>
<br>
Also, where is the documentation change? That should be
part of the very first patch. :)<span class="HOEnZb"><font
color="#888888"><br>
<br>
Philip</font></span>
<div class="HOEnZb">
<div class="h5"><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>