<div dir="ltr">Any comments this renaming patch? It'd be good to get this in before the cut. Thanks!<div><br></div><div>Mark</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 4:13 PM, Mark Heffernan <span dir="ltr"><<a href="mailto:meheff@google.com" target="_blank">meheff@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="">On Fri, Jul 18, 2014 at 4:08 PM, Tyler Nowicki <span dir="ltr"><<a href="mailto:tnowicki@apple.com" target="_blank">tnowicki@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>Looks like the llvm patch was accidentally overwritten by the clang patch.</div>
</div></blockquote><div><br></div></div><div>Whoops. Sorry. Here are both patches again.</div><div><div class="h5"><div><br></div><div>Mark</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div><br></div><div>Tyler</div><div><br></div><div><div><div><div><div>On Jul 18, 2014, at 4:03 PM, Mark Heffernan <<a href="mailto:meheff@google.com" target="_blank">meheff@google.com</a>> wrote:</div>
<br></div></div><blockquote type="cite"><div><div><div dir="ltr">Here's the updated patches. llvm.loop.vectorize.interleave is now llvm.loop.interleave.count.<div class="gmail_extra"><br></div><div class="gmail_extra">
Mark<br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 2:25 PM, Mark Heffernan <span dir="ltr"><<a href="mailto:meheff@google.com" target="_blank">meheff@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>On Fri, Jul 18, 2014 at 2:11 PM, Tyler Nowicki <span dir="ltr"><<a href="mailto:tnowicki@apple.com" target="_blank">tnowicki@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Perhaps you could rename ‘loop.vectorize.unroll' to ‘loop.interleave.count'. That way in a future patch we could add ‘loop.interleave.enable'.<br>
<br>
What do you think?<br></blockquote><div><br></div></div><div>Sounds reasonable. Happy to change it to whatever is most appropriate.</div><span><font color="#888888"><div><br></div><div>Mark</div></font></span><div>
<div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span><font color="#888888"><br>
Tyler<br>
</font></span><div><br>
On Jul 18, 2014, at 1:51 PM, Hal Finkel <<a href="mailto:hfinkel@anl.gov" target="_blank">hfinkel@anl.gov</a>> wrote:<br>
<br>
> Nadav, Arnold,<br>
><br>
> I think this makes sense. Do either of you object?<br>
><br>
> -Hal<br>
><br>
> ----- Original Message -----<br>
>> From: "Mark Heffernan" <<a href="mailto:meheff@google.com" target="_blank">meheff@google.com</a>><br>
>> To: <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a>, "cfe-commits" <<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a>>, "Hal Finkel" <<a href="mailto:hfinkel@anl.gov" target="_blank">hfinkel@anl.gov</a>>, "Tyler<br>
>> Nowicki" <<a href="mailto:tnowicki@apple.com" target="_blank">tnowicki@apple.com</a>><br>
>> Sent: Friday, July 18, 2014 3:44:00 PM<br>
>> Subject: Rename metadata llvm.loop.vectorize.unroll to llvm.loop.vectorize.interleave<br>
>><br>
>><br>
>> This patch rename metadata llvm.loop.vectorize.unroll to<br>
>> llvm.loop.vectorize.interleave to avoid confusion with the<br>
>> concatenation unroller metadata (llvm.loop.unroll). It fell out of a<br>
>> discussion on patch <a href="http://reviews.llvm.org/D4576" target="_blank">http://reviews.llvm.org/D4576</a> . On that patch<br>
>> there was some confusion about whether llvm.loop.vectorize.unroll<br>
>> controlled the traditional (concatenation) loop unroller. And IIRC<br>
>> this isn't the first time there has been this confusion. Renaming<br>
>> vectorize.unroll to vectorize.interleave also more closely matches<br>
>> the pragma which generates the metadata (#pragma clang loop<br>
>> interleave_count). There are still lots of uses of "unroll" within<br>
>> the code in function/variable names and comments. I have no<br>
>> intention of changing those.<br>
>><br>
>><br>
>> Mark<br>
><br>
> --<br>
> Hal Finkel<br>
> Assistant Computational Scientist<br>
> Leadership Computing Facility<br>
> Argonne National Laboratory<br>
<br>
</div></blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>
</div></div><span><rename.llvm.patch></span><span><rename.clang.patch></span></blockquote></div><br></div></div></blockquote></div></div></div><br></div></div>
</blockquote></div><br></div>