<div dir="ltr">+ Duncan<br><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jul 18, 2014 at 1:56 AM, suyog <span dir="ltr"><<a href="mailto:suyog.sarda@samsung.com" target="_blank">suyog.sarda@samsung.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Duncan, Nick<br>
<br>
As there is no guidance in the coding standards,<br>
i looked at few files in InstCombine and comment style in them and<br>
i found it better to include braces, wherever there is a comment inside 'if'.<br>
<br>
if ( ) {<br>
// comment<br>
}<br>
<br>
I removed/didn't add braces where there is no comment and a single statement block.<br>
<br>
Please see if this looks good to you !!<br>
<div class="HOEnZb"><div class="h5"><br>
<a href="http://reviews.llvm.org/D4068" target="_blank">http://reviews.llvm.org/D4068</a><br>
<br>
Files:<br>
  lib/Transforms/InstCombine/InstCombine.h<br>
  lib/Transforms/InstCombine/InstCombineCompares.cpp<br>
  test/Transforms/InstCombine/icmp-shr.ll<br>
</div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>With regards,<br>Suyog Sarda<br>
</div></div></div>