<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Thanks Chandler, Philip<div>I will submit this after fixing the {}.</div><div><br></div><div>Thanks</div><div>Aditya<br><div><blockquote type="cite"><div>On Jul 10, 2014, at 4:34 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 10, 2014 at 4:26 PM, Philip Reames <span dir="ltr"><<a href="mailto:listmail@philipreames.com" target="_blank">listmail@philipreames.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div>On 07/10/2014 04:12 PM, Chandler
Carruth wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Sorry it's taken me a while to get back to this.
<div><br>
</div>
<div>I looked at the patch, and I'm still feeling like there has
to be a more direct way to use the instcombine worklist to
address this problem rather than adding another worklist on
top. Having a feeling isn't a very good code review though. =D
So I grabbed your patch and tried to build a benchmark just as
you suggested to see what the performance difference was and
whether there was another way to achieve it.</div>
</div>
</blockquote></div>
Chandler - Given what you said here, it really sounds like you're
not looking at an up to date version of the patch. There is now no
new worklist. <br>
<br>
Are you looking at Aditya's email from 6/30 10:45 am?</blockquote></div><br></div><div class="gmail_extra">Whoops! Thanks for pointing that out, I had definitely missed that email. Really sorry. *This* patch makes perfect sense to me, LGTM with a tiny nit:</div>
<div class="gmail_extra"><br></div><div class="gmail_extra"><div class="gmail_extra">+ for (Use &U : I->operands()) {</div><div class="gmail_extra">+ if (Instruction *OpI = dyn_cast<Instruction>(U.get())) {</div>
<div class="gmail_extra">+ Worklist.Add(OpI);</div><div class="gmail_extra">+ }</div><div class="gmail_extra">+ }</div><div class="gmail_extra"><br></div><div class="gmail_extra">I'd drop the {}s from both the for and if here...</div>
</div></div>
</div></blockquote></div><br></div></body></html>