<html><head></head><body>Nice work Ulrich, thanks! <br>
<br><br><div class="gmail_quote">On 3 July 2014 18:16:00 EEST, Ulrich Weigand <Ulrich.Weigand@de.ibm.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Hal Finkel <hfinkel@anl.gov> wrote on 03.07.2014 06:03:57:<br /><br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> Here's an updated version of the patch that uses a helper routine<br /> hasBigEndianPartOrdering. It also adds tests to cover the other<br /> changes.<br /><br /> In doing so I noticed that I missed a case in ExpandRes_BITCAST,<br /> and once I added that, it turns out that the original change to<br /> getCopyToParts is not necessary. (This is because that function<br /> first uses a BITCAST to convert to an integer type, and then<br /> operates on the integer type. The endian swap for ppc_fp128<br /> takes place during the BITCAST already; no further swap is<br /> required.)<br /><br /> Does this look OK?<br /></blockquote><br /> Much better, th!
anks!
LGTM.<br /><br /> (Alp, thanks for the suggestion, the logic is indeed much clearer this<br /></blockquote>way).<br /><br />Committed as revision 212274.<br /><br />Thanks again,<br />Ulrich<br /><br /></pre></blockquote></div></body></html>