<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Yep, so we use Postgres internally extensively. <div><br></div><div>Right now, if you make an empty postgres db, and just use the URL in the LNT config file, it will create the tables on first run. That is how I have been doing it. This patch is adding a command line option to do the same thing.</div><div><br></div><div>I think if we are going to expose support for Postgres to users, which I agree we should, we need a new section in the documentation explaining how to do it, and at least a smoke test in test suite to make sure we don’t break support, and a test to make sure the create call works with a postgres URLs. </div><div><br></div><div>Yi, can you add those things to your patch, or in subsequent patches?</div><div><br></div><div>It would also be important to have a section of docs on how to migrate from sqlite to Postgres, as I assume that is the path most users would end up taking.</div><div><br></div><div>We do also have to be careful. There are situations I have found were the same flask queries don’t return the same results on sqlite and Postgres. I have not hit this in LNT, but in development of LNT extensions, so it is something to watch out for!</div><div><br></div><div><br><div><blockquote type="cite"><div>On Jul 2, 2014, at 9:17 AM, Daniel Dunbar <<a href="mailto:daniel@zuster.org">daniel@zuster.org</a>> wrote:</div><br class="Apple-interchange-newline"><div>We run our internal LNT against Postgres and have done so for quite a while, Chris can you check this patch and see why we don't need it? Is it just because we manually updated the configuration?<div><br></div><div> - Daniel<span></span><br>
<br>On Wednesday, July 2, 2014, Yi Kong <<a href="mailto:kongy.dev@gmail.com">kongy.dev@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Patch...<br>
<br>
On 2 July 2014 17:13, Yi Kong <<a href="javascript:;" onclick="_e(event, 'cvml', 'kongy.dev@gmail.com')">kongy.dev@gmail.com</a>> wrote:<br>
> Public LLVM perf server suffers from frequent database locking issues.<br>
> SQLite is suspected to cause the problem as it is not designed for<br>
> multi-user system like LNT.<br>
><br>
> The patch makes LNT compatible with PostgreSQL. Although theoretically<br>
> MySQL should work as well, it's not tested.<br>
><br>
> SQLite is still supported and used by default, since setting up<br>
> PostgreSQL is difficult and unnecessary if deployed locally.<br>
><br>
> To use PostgreSQL, you need to create a pgdb manually:<br>
> CREATE DATABASE "lnt.db";<br>
> And run:<br>
> lnt create SANDBOX --db-dir <a href="postgresql://user@localhost">postgresql://user@localhost</a><br>
><br>
> Cheers,<br>
> Yi<br>
</blockquote></div>
</div></blockquote></div><br></div></body></html>