<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jun 25, 2014 at 9:28 AM, Mark Heffernan <span dir="ltr"><<a href="mailto:meheff@google.com" target="_blank">meheff@google.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">================<br>
Comment at: lib/Transforms/Utils/LoopUnroll.cpp:433<br>
@@ -424,2 +432,3 @@<br>
</div><div class="">       BasicBlock *Dest = Term->getSuccessor(0);<br>
-      if (BasicBlock *Fold = FoldBlockIntoPredecessor(Dest, LI, LPM))<br>
+      if (BasicBlock *Fold = FoldBlockIntoPredecessor(Dest, LI, LPM,<br>
+                                                      LoopForgotten))<br>
</div>----------------<br>
<div class=""><a href="mailto:hfinkel@anl.gov">hfinkel@anl.gov</a> wrote:<br>
> How do you know that LI->getLoopFor(Dest) returns the same Loop for all Dest in this loop?<br>
</div>Good point.  Changed to using a pointer set to keep track of forgotten loops.<br>
<br>
<a href="http://reviews.llvm.org/D4285" target="_blank">http://reviews.llvm.org/D4285</a><br>
<br>
<br>
</blockquote></div><br></div><div class="gmail_extra">Is this part of the code well covered by tests? Maybe some more targeted tests can be crafted.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Eli</div>

<div class="gmail_extra"><br></div><div class="gmail_extra"><br></div><div class="gmail_extra"><br></div></div>