<html><head></head><body>Thanks Rafael! <br>
<br>
<br><br><div class="gmail_quote">On 20 June 2014 14:20:02 BST, "Rafael Espíndola" <rafael.espindola@gmail.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Fixed in r211358.<br /><br />On 20 June 2014 08:57, Rafael Espíndola <rafael.espindola@gmail.com> wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Oh, looks like this found a bug from when target streamers were first<br /> introduced. Fixing.<br /><br /> On 20 June 2014 08:47, Rafael Espíndola <rafael.espindola@gmail.com> wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> It crashes with:<br /><br /> ./bin/llc -O0 -filetype=null<br /> /home/espindola/llvm/llvm/test/DebugInfo/global.ll -o test.o<br /> -mtriple=arm-linux-gnu<br /><br /> On 20 June 2014 08:08, Alp Toker <alp@nuanti.com> wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #8ae234; padding-left: 1ex;"> Do you know how I could get a backtrace? There's not much to go on
here<br /><br /><br /> On 20 June 2014 09:22:02 BST, Renato Golin <renato.golin@linaro.org> wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #fcaf3e; padding-left: 1ex;"><br /> Hi Alp,<br /><br /> This commit is breaking with a segfault on ARM:<br /><br /><br /> <a href="http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a15/builds/1788/steps/check-all/logs/LLVM%3A%3Aglobal.ll">http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a15/builds/1788/steps/check-all/logs/LLVM%3A%3Aglobal.ll</a><br /><br /> cheers,<br /> --renato<br /><br /> On 19 June 2014 18:15, Alp Toker <alp@nuanti.com> wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #e9b96e; padding-left: 1ex;"><br /> Author: alp<br /> Date: Thu Jun 19 12:15:36 2014<br /> New Revision: 211282<br /><br /> URL: <a
href="http://llvm.org/viewvc/llvm-project?rev=211282&view=rev">http://llvm.org/viewvc/llvm-project?rev=211282&view=rev</a><br /> Log:<br /> MCNullStreamer: assign file IDs to resolve crashes and errors<br /><br /> Use the MCStreamer base implementations for file ID tracking instead of<br /> overriding them as<br /> no-ops.<br /><br /> Avoids assertions when streaming Dwarf debug info, and fixes ASM parsing<br /> of loc<br /> and file directives.<br /><br /> Modified:<br /> llvm/trunk/lib/MC/MCNullStreamer.cpp<br /> llvm/trunk/test/DebugInfo/global.ll<br /> llvm/trunk/test/MC/AsmParser/directive_file.s<br /> llvm/trunk/test/MC/AsmParser/directive_line.s<br /> llvm/trunk/test/MC/AsmParser/directive_loc.s<br /><br /> Modified: llvm/trunk/lib/MC/MCNullStreamer.cpp<br /> URL:<br /> <a
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCNullStreamer.cpp?rev=211282&r1=211281&r2=211282&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCNullStreamer.cpp?rev=211282&r1=211281&r2=211282&view=diff</a><br /><hr /><br /><br /> --- llvm/trunk/lib/MC/MCNullStreamer.cpp (original)<br /> +++ llvm/trunk/lib/MC/MCNullStreamer.cpp Thu Jun 19 12:15:36 2014<br /> @@ -81,15 +81,7 @@ namespace {<br /> unsigned char Value = 0) overri!<br /> de {<br /> return false; }<br /><br /><br /> void EmitFileDirective(StringRef Filename) override {}<br /> - unsigned EmitDwarfFileDirective(unsigned FileNo, StringRef<br /> Directory,<br /> - StringRef Filename,<br /> - unsigned CUID = 0) override {<br /> - return 0;<br /> - }<br /> - void EmitDwarfLocDirective(unsigned FileNo, unsigned Line,<br /> - !
unsigned Column, unsigned Flags,<br /> - unsigned Isa, unsigned Discriminator,<br /> - StringRef FileName) override {}<br /> +<br /> void EmitInstruction(const MCInst &Inst, const MCSubtargetInfo&)<br /> override {}<br /><br /> void EmitBundleAlignMode(unsigned AlignPow2) override {}<br /><br /> Modified: llvm/trunk/test/DebugInfo/global.ll<br /> URL:<br /> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/global.ll?rev=211282&r1=211281&r2=211282&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/global.ll?rev=211282&r1=211281&r2=211282&view=diff</a><br /><hr /><br /><br /> --- llvm/trunk/test/DebugInfo/global.ll (original)<br /> +++ llvm/trunk/test/DebugInfo/global.ll Thu Jun 19 12:15:36 2014<br /> @@ -3,6 +3,9 @@<br /> ; RUN: %llc_dwarf -O0 -filetype=obj < %s > %t<br /> ; RUN: llvm-dwarfdump %t | FileCh!
eck
%s<br /><br /> +; Also test that the null streamer doesn't crash with debug info.<br /> +; RUN: %llc_dwarf -O0 -filetype=null < %s<br /> +<br /> ; generated from the following source compiled to bitcode with clang -g<br /> -O1<br /> ; static int i;<br /> ; int main() {<br /><br /> Modified: llvm/trunk/test/MC/AsmParser/directive_file.s<br /> URL:<br /> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AsmParser/directive_file.s?rev=211282&r1=211281&r2=211282&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AsmParser/directive_file.s?rev=211282&r1=211281&r2=211282&view=diff</a><br /><hr /><br /><br /> --- llvm/trunk/test/MC/AsmParser/directive_file.s (original)<br /> +++ llvm/trunk/test/MC/AsmParser/directive_file.s Thu Jun 19 12:15:36<br /> 2014<br /> @@ -1,4 +1,5 @@<br /> # RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s<br /> +# RUN: llvm-mc -triple i386-unknown-unknown %s -filetype=null!
<br
/><br /> .file "hello"<br /> .file 1 "worl\144" # "\144" is "d"<br /><br /> Modified: llvm/trunk/test/MC/AsmParser/directive_line.s<br /> URL:<br /> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AsmParser/directive_line.s?rev=211282&r1=211281&r2=211282&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AsmParser/directive_line.s?rev=211282&r1=211281&r2=211282&view=diff</a><br /><hr /><br /><br /> --- llvm/trunk/test/MC/AsmParser/directive_line.s (original)<br /> +++ llvm/trunk/test/MC/AsmParser/directive_line.s Thu Jun 19 12:15:36<br /> 2014<br /> @@ -1,4 +1,5 @@<br /> # RUN: llvm-mc -triple i386-unknown-unknown %s<br /> +# RUN: llvm-mc -triple i386-unknown-unknown %s -filetype=null<br /> # FIXME: Actually test the output.<br /><br /> .line<br /><br /> Modified: llvm/trunk/test/MC/AsmParser/directive_loc.s<br /> URL:<br /> <a
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AsmParser/directive_loc.s?rev=211282&r1=211281&r2=211282&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AsmParser/directive_loc.s?rev=211282&r1=211281&r2=211282&view=diff</a><br /><hr /><br /><br /> --- llvm/trunk/test/MC/AsmParser/directive_loc.s (original)<br /> +++ llvm/trunk/test/MC/AsmParser/directive_loc.s Thu Jun 19 12:15:36<br /> 2014<br /> @@ -1,4 +1,5 @@<br /> # RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s<br /> +# RUN: llvm-mc -triple i386-unknown-unknown %s -filetype=null<br /><br /> .file 1 "hello"<br /> # CHECK: .file 1 "hello"<br /><br /><br /><hr /><br /><br /> llvm-commits mailing list<br /> llvm-commits@cs.uiuc.edu<br /> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br /></blockquote></blockquote><br /><br /> --<br /> Sent from my Android devi!
ce with
K-9 Mail. Please excuse my brevity.<br /><br /><hr /><br /> llvm-commits mailing list<br /> llvm-commits@cs.uiuc.edu<br /> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></blockquote><br /></blockquote></blockquote></pre></blockquote></div><br>
-- <br>
Sent from my Android device with K-9 Mail. Please excuse my brevity.</body></html>