<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Your change does address a correctness issue and does so in a
reasonable way. I wouldn't worry too much about the possible
performance regression. <br>
<br>
One mandatory change:<br>
- Add a test case which checks the optimization does not apply when
accessed via capturing parameter. <br>
<br>
I'd also prefer that you:<br>
- either use std::distance (rather than iterator subtraction) or
(preferred) use a argument number indexed loop. <br>
- If you keep the iterator loop, consider a range loop. Or at least
move the declaration of B, E into the initializer of the loop to
restrict their scope. <br>
<br>
Philip<br>
<br>
<div class="moz-cite-prefix">On 06/20/2014 06:13 AM, David Wiberg
wrote:<br>
</div>
<blockquote
cite="mid:CACXFvW1KY=XXdT7=sOE86AeP0d97DGXCLrQBiCjG70=tpUvmnQ@mail.gmail.com"
type="cite">
<pre wrap="">Hello,
The attached patch fixes an aliasing issue caused by MemCpyOptimizer
by performing the following changes:
- Added requirement that the callee does not capture the src pointer for
the transformation to apply.
- Updated test cases by adding nocapture attributes where applicable
See <a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-June/073819.html">http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-June/073819.html</a>
for some more information. My main concern is performance regressions
but I haven't been able to get any benchmark results.
Best regards
David
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>