<div dir="ltr">I made a few adjustments:<div><br></div><div><div>+    ConstantInt *C1 = nullptr, *C2 = nullptr;</div><div>+    C1 = dyn_cast<ConstantInt>(C);</div><div>+    C2 = dyn_cast<ConstantInt>(D);</div><div>

became</div><div><div>+    ConstantInt *C1 = dyn_cast<ConstantInt>(C);</div><div>+    ConstantInt *C2 = dyn_cast<ConstantInt>(D);</div></div><div><br></div><div>I removed the dead initialization of V1 and V2 to nullptr. They aren't used unless they match succeeds.</div>

<div><br></div><div class="gmail_extra">Your test had @test1 and @test3, renamed @test3 to @test2.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Changed test to use FileCheck instead of grep. I'm aware this is what InstCombine/apint-or{1,2}.ll does, but it's an older style and FileCheck is preferred.</div>

<div class="gmail_extra"><br></div><div class="gmail_extra">Moved the whole-file comments that apply to each function ("the first test..." and "the second test...") next to the functions they apply to.</div>

<div class="gmail_extra"><br></div><div class="gmail_extra">Committed in r211252. Thanks!</div><div class="gmail_extra"><br></div><div class="gmail_extra">Nick</div><div class="gmail_extra"><br><div class="gmail_quote">On 18 June 2014 07:18, Rahul Jain <span dir="ltr"><<a href="mailto:rahul1.jain@samsung.com" target="_blank">rahul1.jain@samsung.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
Hi Nick,<br>
<br>
Thanks a lot for the review.<br>
Updated patch as per your comment.<br>
1) Sinked variable declarations next to their usage.<br>
2) Folded if statements.<br>
3) Added testcase.<br>
<br>
Please help review the same.<br>
If it looks good to you, please commit it for me.<br>
Soon will ask for commit access.<br>
<div class=""><br>
Thanks,<br>
Rahul<br>
<br>
<a href="http://reviews.llvm.org/D4100" target="_blank">http://reviews.llvm.org/D4100</a><br>
<br>
Files:<br>
  lib/Analysis/InstructionSimplify.cpp<br>
  lib/Transforms/InstCombine/InstCombineAndOrXor.cpp<br>
</div>  test/Transforms/InstSimplify/apint-or.ll<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div></div>