<div dir="ltr">Thanks!  Will wait for Chandler's lgtm as well before I push, since he's had a bunch of comments on past iterations, want to make sure all of his concerns are addressed as well.</div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Tue, Jun 17, 2014 at 2:06 PM, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
lgtm<br>
<br>
================<br>
Comment at: lib/Support/ManagedStatic.cpp:32<br>
@@ +31,3 @@<br>
+// static initialization, so roll our own.<br>
+static std::recursive_mutex& GetManagedStaticMutex() {<br>
+  std::call_once(MutexInitializationFlag,<br>
----------------<br>
The new function naming convention is camelCase over StudlyCaps:<br>
<a href="http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly" target="_blank">http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly</a><br>

<br>
The confusion is understandable, because the existing code is very inconsistent.<br>
<br>
<a href="http://reviews.llvm.org/D4142" target="_blank">http://reviews.llvm.org/D4142</a><br>
<br>
<br>
</blockquote></div><br></div>