<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 16, 2014 at 6:56 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr">Should we just disable gccs warning since clang has a better/more principled version anyway?</p></blockquote>
<div>We may, but it will not help if someone is building sanitizers outside of llvm build system(s), e.g. as part of GCC.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">
<div class="gmail_quote">On Jun 16, 2014 1:53 AM, "Kostya Serebryany" <<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

Author: kcc<br>
Date: Mon Jun 16 03:32:02 2014<br>
New Revision: 211008<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=211008&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=211008&view=rev</a><br>
Log:<br>
[asan] initialze varaibles to avoid a (false positive) report from gcc's -Wmaybe-uninitialized<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc?rev=211008&r1=211007&r2=211008&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc?rev=211008&r1=211007&r2=211008&view=diff</a><br>


==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_interceptors.inc Mon Jun 16 03:32:02 2014<br>
@@ -1812,7 +1812,7 @@ INTERCEPTOR(int, getsockopt, int sockfd,<br>
 INTERCEPTOR(int, accept, int fd, void *addr, unsigned *addrlen) {<br>
   void *ctx;<br>
   COMMON_INTERCEPTOR_ENTER(ctx, accept, fd, addr, addrlen);<br>
-  unsigned addrlen0;<br>
+  unsigned addrlen0 = 0;<br>
   if (addrlen) {<br>
     COMMON_INTERCEPTOR_READ_RANGE(ctx, addrlen, sizeof(*addrlen));<br>
     addrlen0 = *addrlen;<br>
@@ -1834,7 +1834,7 @@ INTERCEPTOR(int, accept, int fd, void *a<br>
 INTERCEPTOR(int, accept4, int fd, void *addr, unsigned *addrlen, int f) {<br>
   void *ctx;<br>
   COMMON_INTERCEPTOR_ENTER(ctx, accept4, fd, addr, addrlen, f);<br>
-  unsigned addrlen0;<br>
+  unsigned addrlen0 = 0;<br>
   if (addrlen) {<br>
     COMMON_INTERCEPTOR_READ_RANGE(ctx, addrlen, sizeof(*addrlen));<br>
     addrlen0 = *addrlen;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</div></div></blockquote></div><br></div></div>