<div dir="ltr">I'm still really not happy with the approach for the global lock. This is completely different from the approach you and I discussed, on a separate patch with a separate review thread. Please *do not* fork reviews in this way. Please revert this and resume the code review on the original thread. =/ I'm sorry if you're frustrated by the time it is taking to get this in, but when one person has expressed specific concerns, I think it is a mistake to move forward without sync-ing back up with them.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 16, 2014 at 9:24 AM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Closed by commit rL210600 (authored by @zturner).<br>
<br>
<a href="http://reviews.llvm.org/D4076" target="_blank">http://reviews.llvm.org/D4076</a><br>
<br>
Files:<br>
  llvm/trunk/include/llvm-c/Core.h<br>
  llvm/trunk/include/llvm/Support/ManagedStatic.h<br>
  llvm/trunk/include/llvm/Support/Threading.h<br>
  llvm/trunk/lib/IR/Core.cpp<br>
  llvm/trunk/lib/Support/ErrorHandling.cpp<br>
  llvm/trunk/lib/Support/ManagedStatic.cpp<br>
  llvm/trunk/lib/Support/Threading.cpp<br>
  llvm/trunk/lib/Support/Timer.cpp<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>