<div dir="ltr"><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Jun 6, 2014 at 5:44 AM, Sergey Matveev <span dir="ltr"><<a href="mailto:earthdok@google.com" target="_blank">earthdok@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Makes sense, but maybe we should refactor to use SanitizerCommonDecorator instead. I'll let UBSan folks have their say.</div>
</blockquote><div><br></div><div>Submitted as r210950.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div class="h5"><br><div class="gmail_extra">
<br><br><div class="gmail_quote">On Fri, Jun 6, 2014 at 1:20 PM, Stephan Bergmann <span dir="ltr"><<a href="mailto:sbergman@redhat.com" target="_blank">sbergman@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 06/04/2014 07:05 PM, Sergey Matveev wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks, fixed in r210199.<br>
</blockquote>
<br>
...and, in a similar vein, for ubsan (it cannot simply use SanitizerCommonDecorator as that inherits AnsiColorDecorator protected). Works at least when -fsanitize=undefined is used in combination with another sanitizer like -fsanitize=address and ASAN_OPTIONS=color=always:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Index: lib/ubsan/ubsan_diag.cc<br>
==============================<u></u>==============================<u></u>=======<br>
--- lib/ubsan/ubsan_diag.cc (revision 210250)<br>
+++ lib/ubsan/ubsan_diag.cc (working copy)<br>
@@ -265,7 +265,7 @@<br>
}<br>
<br>
Diag::~Diag() {<br>
- __sanitizer::<u></u>AnsiColorDecorator Decor(PrintsToTty());<br>
+ __sanitizer::<u></u>AnsiColorDecorator Decor(ColorizeReports());<br>
SpinMutexLock l(&CommonSanitizerReportMutex)<u></u>;<br>
Printf(Decor.Bold());<br>
<br>
</blockquote>
<br>
Stephan<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Generally, compiler-rt patches should be posted to llvm-commits, not<br>
cfe-commits.<br>
<br>
<br>
On Wed, Jun 4, 2014 at 8:12 PM, Stephan Bergmann <<a href="mailto:sbergman@redhat.com" target="_blank">sbergman@redhat.com</a><br>
<mailto:<a href="mailto:sbergman@redhat.com" target="_blank">sbergman@redhat.com</a>>> wrote:<br>
<br>
The below change to trunk projects/compiler-rt makes<br>
ASAN_OPTIONS=detect_leaks=1:__<u></u>color=always colorize the<br>
LeakSanitizer output as intended:<br>
<br>
Index: lib/lsan/lsan_common.cc<br>
==============================<u></u>__============================<u></u>==__=======<br>
--- lib/lsan/lsan_common.cc (revision 210183)<br>
+++ lib/lsan/lsan_common.cc (working copy)<br>
@@ -133,7 +133,7 @@<br>
<br>
class Decorator: private __sanitizer::__<u></u>AnsiColorDecorator {<br>
public:<br>
- Decorator() :<br>
__sanitizer::__<u></u>AnsiColorDecorator(__<u></u>PrintsToTtyCached()) { }<br>
+ Decorator() :<br>
__sanitizer::__<u></u>AnsiColorDecorator(__<u></u>ColorizeReports()) { }<br>
const char *Error() { return Red(); }<br>
const char *Leak() { return Blue(); }<br>
const char *End() { return Default(); }<br>
</blockquote>
<br>
</blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div>
</div></div>