<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">I changed the name from IM to InstructionMerger and acknowledge it is not ideal, but neither are the alternative proposals. Does anyone else feel strongly against the name?<div><br></div><div>Thanks</div><div>Gerolf</div><div><br><div><div>On Jun 11, 2014, at 10:34 AM, Philip Reames <<a href="mailto:firstname.lastname@example.org">email@example.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type">
<div bgcolor="#FFFFFF" text="#000000">
As I said in the other thread, I do not support the current name.
Here are a few ideas:<br>
- You're hoisting and sinking loads and stores across branches.
- This is analogous to LICM, but without loops. Maybe: BranchICM?
I would argue *strongly* that the current name should not be
accepted. It is not descriptive and is actively confusing. <br>
The rest of my comments will be on the phabricator review. I wanted
to continue this in email since that's where it had previously
<div class="moz-cite-prefix">On 06/10/2014 01:43 PM, Gerolf
<blockquote cite="mid:differential-rev-PHID-DREVfirstname.lastname@example.org" type="cite">
<pre wrap="">Hi chandlerc,
This pass iteratively hoists two loads to the same address out of a diamond (hammock) and merges them
into a single load in the header. Similar it sinks and merges two stores to the tail block. The algorithm
iterates over the instructions of one side of the diamond and attempts to find a matching load/store on
the other side. It hoists / sinks when it thinks it safe to do so. I tailored the code as conservative as possible to catch the initial cases we are interested in, which keeps code size and complexity in check. The optimization helps hiding load latencies and triggering if-conversion.
<a class="moz-txt-link-freetext" href="http://reviews.llvm.org/D4096">http://reviews.llvm.org/D4096</a>
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:email@example.com">firstname.lastname@example.org</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>