<div dir="ltr">Reverted in r210574, because the test case doesn't actually make sense.  It's disassembling '.seh_pushreg %rsi' as '.seh_pushreg %rbp'.</div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Fri, Apr 18, 2014 at 10:40 PM, Yaron Keren <span dir="ltr"><<a href="mailto:yaron.keren@gmail.com" target="_blank">yaron.keren@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: yrnkrn<br>
Date: Sat Apr 19 00:40:09 2014<br>
New Revision: 206683<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=206683&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=206683&view=rev</a><br>
Log:<br>
Patch by Ray Donnelly to print register names instead of numbers.<br>
<br>
<a href="http://reviews.llvm.org/D3422" target="_blank">http://reviews.llvm.org/D3422</a><br>
<br>
<br>
Modified:<br>
    llvm/trunk/lib/MC/MCAsmStreamer.cpp<br>
    llvm/trunk/test/MC/AsmParser/directive_seh.s<br>
<br>
Modified: llvm/trunk/lib/MC/MCAsmStreamer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAsmStreamer.cpp?rev=206683&r1=206682&r2=206683&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAsmStreamer.cpp?rev=206683&r1=206682&r2=206683&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/MC/MCAsmStreamer.cpp (original)<br>
+++ llvm/trunk/lib/MC/MCAsmStreamer.cpp Sat Apr 19 00:40:09 2014<br>
@@ -1257,14 +1257,17 @@ void MCAsmStreamer::EmitWin64EHHandlerDa<br>
 void MCAsmStreamer::EmitWin64EHPushReg(unsigned Register) {<br>
   MCStreamer::EmitWin64EHPushReg(Register);<br>
<br>
-  OS << "\t.seh_pushreg " << Register;<br>
+  OS << "\t.seh_pushreg ";<br>
+  EmitRegisterName(Register);<br>
   EmitEOL();<br>
 }<br>
<br>
 void MCAsmStreamer::EmitWin64EHSetFrame(unsigned Register, unsigned Offset) {<br>
   MCStreamer::EmitWin64EHSetFrame(Register, Offset);<br>
<br>
-  OS << "\t.seh_setframe " << Register << ", " << Offset;<br>
+  OS << "\t.seh_setframe ";<br>
+  EmitRegisterName(Register);<br>
+  OS << ", " << Offset;<br>
   EmitEOL();<br>
 }<br>
<br>
@@ -1278,14 +1281,18 @@ void MCAsmStreamer::EmitWin64EHAllocStac<br>
 void MCAsmStreamer::EmitWin64EHSaveReg(unsigned Register, unsigned Offset) {<br>
   MCStreamer::EmitWin64EHSaveReg(Register, Offset);<br>
<br>
-  OS << "\t.seh_savereg " << Register << ", " << Offset;<br>
+  OS << "\t.seh_savereg ";<br>
+  EmitRegisterName(Register);<br>
+  OS << ", " << Offset;<br>
   EmitEOL();<br>
 }<br>
<br>
 void MCAsmStreamer::EmitWin64EHSaveXMM(unsigned Register, unsigned Offset) {<br>
   MCStreamer::EmitWin64EHSaveXMM(Register, Offset);<br>
<br>
-  OS << "\t.seh_savexmm " << Register << ", " << Offset;<br>
+  OS << "\t.seh_savexmm ";<br>
+  EmitRegisterName(Register);<br>
+  OS << ", " << Offset;<br>
   EmitEOL();<br>
 }<br>
<br>
<br>
Modified: llvm/trunk/test/MC/AsmParser/directive_seh.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AsmParser/directive_seh.s?rev=206683&r1=206682&r2=206683&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/AsmParser/directive_seh.s?rev=206683&r1=206682&r2=206683&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/test/MC/AsmParser/directive_seh.s (original)<br>
+++ llvm/trunk/test/MC/AsmParser/directive_seh.s Sat Apr 19 00:40:09 2014<br>
@@ -3,10 +3,10 @@<br>
 # CHECK: .seh_proc func<br>
 # CHECK: .seh_pushframe @code<br>
 # CHECK: .seh_stackalloc 24<br>
-# CHECK: .seh_savereg 6, 16<br>
-# CHECK: .seh_savexmm 8, 0<br>
-# CHECK: .seh_pushreg 3<br>
-# CHECK: .seh_setframe 3, 0<br>
+# CHECK: .seh_savereg %rbp, 16<br>
+# CHECK: .seh_savexmm %r8, 0<br>
+# CHECK: .seh_pushreg %rbx<br>
+# CHECK: .seh_setframe %rbx, 0<br>
 # CHECK: .seh_endprologue<br>
 # CHECK: .seh_handler __C_specific_handler, @except<br>
 # CHECK-NOT: .section{{.*}}.xdata<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>